Skip to content

Only save login credentials in database once there is an external storage that needs it #21037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blizzz merged 4 commits into from
Aug 7, 2020
Merged

Only save login credentials in database once there is an external storage that needs it #21037

blizzz merged 4 commits into from
Aug 7, 2020

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented May 18, 2020 •
edited by MorrisJobke
Loading

Also fixes #6343

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label May 18, 2020
@icewind1991 icewind1991 added this to the Nextcloud 20 milestone May 18, 2020
@kesselb kesselb mentioned this pull request May 19, 2020
Closed
@kesselb
Copy link
Contributor

kesselb commented May 19, 2020

This patch also helps with #6343 as the data is not written anymore on login.

How do you detect changed credentials without listening to postLogin?

@icewind1991 icewind1991 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 20, 2020
@icewind1991
Copy link
Member Author

icewind1991 commented May 20, 2020

How do you detect changed credentials without listening to postLogin?

Forgot about that 🙈 , will need to add something for that

@icewind1991
Copy link
Member Author

icewind1991 commented May 20, 2020

How do you detect changed credentials without listening to postLogin?

Forgot about that see_no_evil , will need to add something for that

done

@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 20, 2020
@icewind1991 icewind1991 force-pushed the login-credentails-save branch from d2b31d6 to c89db6c Compare May 20, 2020 14:01
@kesselb
Copy link
Contributor

kesselb commented May 20, 2020

done

Nice 👍 Much cleaner than before and will still help with #6343 as the password is only updated on change 🚀

@icewind1991 icewind1991 force-pushed the login-credentails-save branch from c89db6c to 39c0e4b Compare May 20, 2020 14:32
MorrisJobke
MorrisJobke reviewed May 25, 2020
View reviewed changes
@icewind1991 icewind1991 force-pushed the login-credentails-save branch from 39c0e4b to 48909ff Compare May 26, 2020 14:47
@kesselb
Copy link
Contributor

kesselb commented Jul 25, 2020

@rullzer @MorrisJobke @juliushaertl 🏓

MorrisJobke
MorrisJobke reviewed Jul 30, 2020
View reviewed changes
MorrisJobke
MorrisJobke reviewed Jul 30, 2020
View reviewed changes
@icewind1991 @MorrisJobke
Only save login credentials in database once there is an external sto…
7ad0f66 
…rage that needs it

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @MorrisJobke
remove saved credentails if the user no longer has any storage config…
c864e5d 
…ured using them

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @MorrisJobke
update saved credentials on password change
d1bd3ba 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@MorrisJobke
Copy link
Member

MorrisJobke commented Jul 30, 2020

Let me fix this :)

@MorrisJobke MorrisJobke force-pushed the login-credentails-save branch from 48909ff to 91cfd49 Compare July 30, 2020 09:53
@MorrisJobke
Move event listener to dedicated class
0b0cc48 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke force-pushed the login-credentails-save branch from 91cfd49 to 0b0cc48 Compare July 30, 2020 10:05
MorrisJobke
MorrisJobke approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@faily-bot
Copy link

faily-bot bot commented Jul 30, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31206: failure

mysql8.0-php7.2

Show full log 
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testCopyDirectory
Failed asserting that false is true.

/drone/src/tests/lib/Files/Storage/Storage.php:550

integration-external-storage

Could not fetch logs

@blizzz blizzz merged commit a2c262b into master Aug 7, 2020
@blizzz blizzz deleted the login-credentails-save branch August 7, 2020 10:49
@krono krono mentioned this pull request Aug 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@blizzz blizzz blizzz approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@kesselb kesselb Awaiting requested review from kesselb

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

PostgreSQL : duplicate key value violates unique constraint error message

5 participants

@icewind1991 @kesselb @MorrisJobke @blizzz