Copy over the ETag and LastModified when formatting a Dataresponse #21041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the ETag checks etc are all working. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
ChristophWurst,
MorrisJobke,
juliusknorr,
korelstar and
nickvergessen
ChristophWurst
approved these changes
May 19, 2020
korelstar
reviewed
May 19, 2020
Member
korelstar
left a comment
korelstar
left a comment
There was a problem hiding this comment.
With these changes, ETag/If-None-Match works also for DataResponse. But what about the other fields from DataResponse (respective Response) like cookies, contentSecurityPolicy etc. ? Shouldn't they also be copied?
Member
|
Can we backport this fix? |
korelstar
approved these changes
May 19, 2020
Member
|
/backport to stable19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the ETag checks etc are all working.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl