fixes infinitely repeating LDPA search results with PHP <= 7.2 #21108
Conversation
blizzz
requested review from
Dennis1993,
MorrisJobke,
juliusknorr,
rullzer and
splitt3r
|
/backport to stable19 |
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/20745/eor-old-php-api
branch
from
9a9f830 to
15008a1
Compare
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Code looks good, however I fail to reproduce the issue on my PHP 7.2 instance, so I cannot verify that it actually works 🙈
| if (!$this->hasMoreResults()) { | ||
| // when the cookie is reset with != 0 offset, there are no further | ||
| // results, so stop. This if block is not necessary with new API | ||
| // and can be removed with dropping PHP 7.2 |
There was a problem hiding this comment.
Why can we remove this block when we drop PHP 7.2 when this solves an issue that occured on 7.4 (#20745)?
Or is that new API not implemented yet?
There was a problem hiding this comment.
I failed to reproduce it on 7.4 for some unknown reason. Ought to double check and remove this part of the comment.
|
One word of caution for those applying this fix (and maybe something that can be automatically solved in the release): This bug caused the Now, this fix would solve the issue regarding the ever-increasing offset, but the cron job now fails before that can happen because of the recursion error. It's solved by manually forcing the offset to zero. |
fixes #20745