Skip to content

Reduce contacts search load #21222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Jul 6, 2020
Merged

Reduce contacts search load #21222

MorrisJobke merged 1 commit into from
Jul 6, 2020

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jun 4, 2020 •
edited
Loading

@nickvergessen nickvergessen added this to the Nextcloud 20 milestone Jun 4, 2020
@nickvergessen
Reduce load of the contacts search when we know it can't match
00e7b2b 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/18965/reduce-contacts-search-load branch from d40cc23 to 00e7b2b Compare June 15, 2020 06:47
@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 15, 2020

Rebased, ready for review now

ChristophWurst
ChristophWurst approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐘

MorrisJobke
MorrisJobke approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke MorrisJobke merged commit db782fe into master Jul 6, 2020
@MorrisJobke MorrisJobke deleted the bugfix/18965/reduce-contacts-search-load branch July 6, 2020 11:56
@fladi fladi mentioned this pull request Jul 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@georgehrke georgehrke Awaiting requested review from georgehrke

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: dav

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

Use FTS for contact search instead of LIKE

4 participants

@nickvergessen @MorrisJobke @ChristophWurst