theming: move reset button into field and only show when focused

[jancborchardt]

As per #2134, makes the buttons way less obnoxious. Please review @nextcloud/designers @nextcloud/theming

Before & after

[mention-bot]

@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @juliushaertl and @schiessle to be potential reviewers.

[juliusknorr]

@jancborchardt Wouldn't it make more sense to show them when hovering the fields? That way they were still hidden, but in case you want to reset some value there will be only one click instead of one.

Even without the hover: 👍

[jancborchardt]

@juliushaertl I had it with hover before, but then it looked strange because when you focus one field and hover another, two reset icons are shown.

[stefan-niedermann]

Wouldn't it make more sense to show them when hovering the fields?

Don't forget touch only devices. The focus-solution will work in both cases pretty. If you use hover on desktop, mobile devices have to show the button always, so there would be no benefit.

[juliusknorr]

@jancborchardt @stefan-niedermann Ok, makes sense. 😉

[jancborchardt]

@stefan-niedermann so, can I get a plus-one / thumbs-up from you? ;D

[skjnldsv]

@jancborchardt don't be gready! 😉

[jancborchardt]

@skjnldsv gimme! 😠 😄

[MorrisJobke]

👍

[MorrisJobke]

@jancborchardt Could you create a "show always" for mobile in a separate PR? Thanks ;)

[jancborchardt]

@MorrisJobke for mobile it’s also intended to be exactly like this. :) Tap into a field, then you can reset.

[stefan-niedermann]

yeah, thumbs up! :D