Skip to content

S3 objectstore ci #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 2 commits into from
Jan 2, 2017
Merged

S3 objectstore ci #2159

MorrisJobke merged 2 commits into from
Jan 2, 2017

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Nov 16, 2016 •
edited by rullzer
Loading

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Nov 16, 2016
@icewind1991 icewind1991 added this to the Nextcloud 11.0 milestone Nov 16, 2016
@mention-bot
Copy link

mention-bot commented Nov 16, 2016

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @butonic, @PVince81 and @berendt to be potential reviewers.

@rullzer rullzer mentioned this pull request Nov 16, 2016
Merged
@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 16, 2016

Fails:

1) OCA\Files\Tests\Service\TagServiceTest::testUpdateFileTags
563s
110
OCP\Files\StorageNotAvailableException: 
563s
112
/drone/src/github.com/nextcloud/server/lib/private/Files/Storage/Wrapper/Availability.php:76
563s
113
/drone/src/github.com/nextcloud/server/lib/private/Files/Storage/Wrapper/Availability.php:239
563s
114
/drone/src/github.com/nextcloud/server/lib/private/Files/View.php:1293
563s
115
/drone/src/github.com/nextcloud/server/lib/private/Files/View.php:1339
563s
116
/drone/src/github.com/nextcloud/server/lib/private/Files/Node/Root.php:196
563s
117
/drone/src/github.com/nextcloud/server/lib/private/Files/Node/Folder.php:122
563s
118
/drone/src/github.com/nextcloud/server/lib/private/Files/AppData/AppData.php:105
563s
119
/drone/src/github.com/nextcloud/server/lib/private/Preview/Watcher.php:61
563s
120
/drone/src/github.com/nextcloud/server/lib/private/Preview/WatcherConnector.php:60
563s
121
/drone/src/github.com/nextcloud/server/lib/private/Hooks/EmitterTrait.php:99
563s
122
/drone/src/github.com/nextcloud/server/lib/private/Hooks/PublicEmitter.php:33
563s
123
/drone/src/github.com/nextcloud/server/lib/private/Files/Node/Root.php:134
563s
124
/drone/src/github.com/nextcloud/server/lib/private/Files/Node/Folder.php:172
563s
125
/drone/src/github.com/nextcloud/server/apps/files/tests/Service/TagServiceTest.php:97

@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 18, 2016

@icewind1991 Required PR is merged ;) Fix this! 😉

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Nov 18, 2016
@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 30, 2016

@icewind1991 Ping

@LukasReschke
Copy link
Member

LukasReschke commented Dec 11, 2016

@icewind1991 Can we move that to 12? I'd prefer to consider 11 closed for any non-critical merges.

@rullzer
Copy link
Member

rullzer commented Dec 16, 2016

@icewind1991 care to finish this? I'd love to have tests in place.

@MorrisJobke
Copy link
Member

MorrisJobke commented Dec 22, 2016

@icewind1991 Ping ;)

@icewind1991 icewind1991 requested a review from rullzer December 29, 2016 13:52
@icewind1991
Copy link
Member Author

icewind1991 commented Dec 29, 2016

Changed this so it only includes the object store tests themselves, and not run all tests with object store configured.

That way we can at least get this tests merged and I'll open a separate issue/pr for the rest

cc @MorrisJobke @LukasReschke @rullzer please review

MorrisJobke
MorrisJobke reviewed Jan 2, 2017
View reviewed changes
autotest.sh Outdated

# reset data directory
rm -rf "$DATADIR"
rm -rf "$DATADIR"f
Copy link
Member

@MorrisJobke MorrisJobke Jan 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

Copy link
Member Author

@icewind1991 icewind1991 Jan 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 2, 2017
@icewind1991 @rullzer
add ci support for s3 object store
ac2542f 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @rullzer
adjust test
3243a60 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@rullzer rullzer force-pushed the s3-objectstore-ci branch from 9ea4d76 to 3243a60 Compare January 2, 2017 13:17
@rullzer
Copy link
Member

rullzer commented Jan 2, 2017

I rebased to make CI happy

@MorrisJobke MorrisJobke merged commit 61720bf into master Jan 2, 2017
@MorrisJobke MorrisJobke deleted the s3-objectstore-ci branch January 2, 2017 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 12.0

Development

Successfully merging this pull request may close these issues.

6 participants

@icewind1991 @mention-bot @MorrisJobke @LukasReschke @rullzer