OCS person to controller #2170
Merged
OCS person to controller #2170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tomneedham, @owncloud-bot and @nickvergessen to be potential reviewers. |
Member
Author
|
to test: |
Member
|
LGTM |
LukasReschke
approved these changes
Nov 17, 2016
Member
|
Your command didn't work, because the parameter should be password, not pass. |
MorrisJobke
added a commit
that referenced
this pull request
Mar 3, 2017
* Person was removed via #2170 * other lcasses/interfaces are not used at all Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the
ocs/person/checkover to the OCSController. So we can haz unit tests now!CC: @LukasReschke @nickvergessen @MorrisJobke @icewind1991