Skip to content

Use DOMContentLoaded and fix sharebymail loading issue #21921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 1 commit into from
Jul 20, 2020
Merged

Use DOMContentLoaded and fix sharebymail loading issue #21921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/dav/js/schedule-response.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
// $(document).ready(function() {
// window.addEventListener('DOMContentLoaded', function() {
// $('#selectPartStatForm').buttonset();
// });
2 changes: 1 addition & 1 deletion apps/encryption/js/encryption.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ OC.Encryption = _.extend(OC.Encryption || {}, {
);
}
});
$(document).ready(function() {
window.addEventListener('DOMContentLoaded', function() {
// wait for other apps/extensions to register their event handlers and file actions
// in the "ready" clause
_.defer(function() {
Expand Down
2 changes: 1 addition & 1 deletion apps/encryption/js/settings-admin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* See the COPYING-README file.
*/

$(document).ready(function () {
window.addEventListener('DOMContentLoaded', function () {

$('input:button[name="enableRecoveryKey"]').click(function () {

Expand Down
2 changes: 1 addition & 1 deletion apps/encryption/js/settings-personal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ OC.Encryption = _.extend(OC.Encryption || {}, {
}
});

$(document).ready(function () {
window.addEventListener('DOMContentLoaded', function () {

// Trigger ajax on recoveryAdmin status change
$('input:radio[name="userEnableRecovery"]').change(
Expand Down
2 changes: 1 addition & 1 deletion apps/federatedfilesharing/js/settings-admin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
$(document).ready(function() {
window.addEventListener('DOMContentLoaded', function() {

$('#fileSharingSettings input').change(function() {
var value = 'no';
Expand Down
2 changes: 1 addition & 1 deletion apps/federatedfilesharing/js/settings-personal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
$(document).ready(function() {
window.addEventListener('DOMContentLoaded', function() {

$('#fileSharingSettings button.pop-up').click(function() {
var url = $(this).data('url');
Expand Down
2 changes: 1 addition & 1 deletion apps/federation/js/settings-admin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@

})( jQuery );

$(document).ready(function () {
window.addEventListener('DOMContentLoaded', function () {

$('#ocFederationSettings').ocFederationAddServer();

Expand Down
2 changes: 1 addition & 1 deletion apps/files/js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@
};
})();

$(document).ready(function() {
window.addEventListener('DOMContentLoaded', function() {
// wait for other apps/extensions to register their event handlers and file actions
// in the "ready" clause
_.defer(function() {
Expand Down
2 changes: 1 addition & 1 deletion apps/files/js/dist/files-app-settings.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/files/js/dist/sidebar.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/files/js/favoritesfilelist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
*/

// HACK: this piece needs to be loaded AFTER the files app (for unit tests)
$(document).ready(function() {
window.addEventListener('DOMContentLoaded', function() {
(function(OCA) {
/**
* @class OCA.Files.FavoritesFileList
Expand Down
4 changes: 2 additions & 2 deletions apps/files/js/filelist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@
return;
}

if (!fileName) {
if (!fileName && OCA.Files.Sidebar.close) {
OCA.Files.Sidebar.close()
return
} else if (typeof fileName !== 'string') {
Expand Down Expand Up @@ -3839,7 +3839,7 @@
OCA.Files.FileList = FileList;
})();

$(document).ready(function() {
window.addEventListener('DOMContentLoaded', function() {
// FIXME: unused ?
OCA.Files.FileList.useUndo = (window.onbeforeunload)?true:false;
$(window).on('beforeunload', function () {
Expand Down
2 changes: 1 addition & 1 deletion apps/files/js/recentfilelist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
*/

// HACK: this piece needs to be loaded AFTER the files app (for unit tests)
$(document).ready(function () {
window.addEventListener('DOMContentLoaded', function () {
(function (OCA) {
/**
* @class OCA.Files.RecentFileList
Expand Down
2 changes: 1 addition & 1 deletion apps/files/src/files-app-settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ if (!window.OCA.Files) {
Object.assign(window.OCA.Files, { Settings: new Settings() })
Object.assign(window.OCA.Files.Settings, { Setting })

window.addEventListener('DOMContentLoaded', () => {
window.addEventListener('DOMContentLoaded', function() {
// Init Vue app
// eslint-disable-next-line
new Vue({
Expand Down
2 changes: 1 addition & 1 deletion apps/files/src/sidebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ if (!window.OCA.Files) {
Object.assign(window.OCA.Files, { Sidebar: new Sidebar() })
Object.assign(window.OCA.Files.Sidebar, { Tab })

window.addEventListener('DOMContentLoaded', () => {
window.addEventListener('DOMContentLoaded', function() {
// Make sure we have a proper layout
if (document.getElementById('content')) {

Expand Down
2 changes: 1 addition & 1 deletion apps/files_external/js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ OCA.Files_External.App = {
}
};

$(document).ready(function() {
window.addEventListener('DOMContentLoaded', function() {
$('#app-content-extstoragemounts').on('show', function(e) {
OCA.Files_External.App.initList($(e.target));
});
Expand Down
2 changes: 1 addition & 1 deletion apps/files_external/js/oauth1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
$(document).ready(function() {
window.addEventListener('DOMContentLoaded', function() {

function displayGranted($tr) {
$tr.find('.configuration input.auth-param').attr('disabled', 'disabled').addClass('disabled-success');
Expand Down
2 changes: 1 addition & 1 deletion apps/files_external/js/oauth2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
$(document).ready(function() {
window.addEventListener('DOMContentLoaded', function() {

function displayGranted($tr) {
$tr.find('.configuration input.auth-param').attr('disabled', 'disabled').addClass('disabled-success');
Expand Down
2 changes: 1 addition & 1 deletion apps/files_external/js/public_key.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
$(document).ready(function() {
window.addEventListener('DOMContentLoaded', function() {

OCA.Files_External.Settings.mountConfig.whenSelectAuthMechanism(function($tr, authMechanism, scheme, onCompletion) {
if (scheme === 'publickey' && authMechanism === 'publickey::rsa') {
Expand Down
2 changes: 1 addition & 1 deletion apps/files_external/js/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1295,7 +1295,7 @@ MountConfigListView.prototype = _.extend({
}
}, OC.Backbone.Events);

$(document).ready(function() {
window.addEventListener('DOMContentLoaded', function() {
var enabled = $('#files_external').attr('data-encryption-enabled');
var encryptionEnabled = (enabled ==='true')? true: false;
var mountConfigListView = new MountConfigListView($('#externalStorage'), {
Expand Down
2 changes: 1 addition & 1 deletion apps/files_sharing/js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ OCA.Sharing.App = {
},
}

$(document).ready(function() {
window.addEventListener('DOMContentLoaded', function() {
$('#app-content-sharingin').on('show', function(e) {
OCA.Sharing.App.initSharingIn($(e.target))
})
Expand Down
Loading