Move NotFoundResponse to a proper TemplateResponse

[juliusknorr]

Make sure that BeforeTemplateRenderedEvent is properly emitted on NotFoundResponses.

For #21818

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31070: failure

mysql5.6-php7.2

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'

/drone/src/apps/files_versions/tests/VersioningTest.php:729

integration-auth

• build/integration/features/auth.feature:70

Show full log

  Scenario: using OCS anonymously                                                    # /drone/src/build/integration/features/auth.feature:70
[Fri Jul 24 07:02:47 2020] 127.0.0.1:38268 [404]: /ocs/v2.php/cloud/users/user0
[Fri Jul 24 07:02:47 2020] 127.0.0.1:38276 [200]: /ocs/v1.php/cloud/users
[Fri Jul 24 07:02:48 2020] 127.0.0.1:38282 [200]: /ocs/v1.php/cloud/users/user0
[Fri Jul 24 07:02:48 2020] 127.0.0.1:38286 [200]: /ocs/v2.php/cloud/users/user0
[Fri Jul 24 07:02:48 2020] 127.0.0.1:38296 [200]: /login
[Fri Jul 24 07:02:48 2020] 127.0.0.1:38300 [303]: /login
[Fri Jul 24 07:02:48 2020] 127.0.0.1:38310 [200]: /index.php/apps/files/
[Fri Jul 24 07:02:49 2020] 127.0.0.1:38314 [200]: /index.php/settings/personal/authtokens
[Fri Jul 24 07:02:49 2020] 127.0.0.1:38318 [200]: /index.php/settings/personal/authtokens/56
[Fri Jul 24 07:02:49 2020] 127.0.0.1:38322 [303]: /login
[Fri Jul 24 07:02:49 2020] 127.0.0.1:38324 [200]: /index.php/apps/files/
[Fri Jul 24 07:02:49 2020] 127.0.0.1:38326 [303]: /login
[Fri Jul 24 07:02:49 2020] 127.0.0.1:38342 [200]: /index.php/apps/files/
[Fri Jul 24 07:02:49 2020] 127.0.0.1:38348 [200]: /index.php/settings/personal/authtokens
[Fri Jul 24 07:02:49 2020] TypeError: Argument 11 passed to OCA\Files_Sharing\External\Manager::__construct() must be of the type string, null given, called in /drone/src/apps/files_sharing/lib/AppInfo/Application.php on line 98 at /drone/src/apps/files_sharing/lib/External/Manager.php#91
[Fri Jul 24 07:02:49 2020] 127.0.0.1:38350 [200]: /ocs/v1.php/apps/files_sharing/api/v1/remote_shares
    When requesting "/ocs/v1.php/apps/files_sharing/api/v1/remote_shares" with "GET" # FeatureContext::requestingWith()
    Then the OCS status code should be "997"                                         # FeatureContext::theOCSStatusCodeShouldBe()
      Notice: Trying to get property 'meta' of non-object in /drone/src/build/integration/features/bootstrap/BasicStructure.php line 153
[Fri Jul 24 07:02:49 2020] 127.0.0.1:38352 [200]: /ocs/v1.php/cloud/users/user0
[Fri Jul 24 07:02:50 2020] 127.0.0.1:38378 [404]: /ocs/v2.php/cloud/users/user0
[Fri Jul 24 07:02:50 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Fri Jul 24 07:02:50 2020] 127.0.0.1:38392 [401]: /remote.php/webdav/myFileToComment.txt
[Fri Jul 24 07:02:50 2020] 127.0.0.1:38394 [207]: /remote.php/dav/systemtags/
[Fri Jul 24 07:02:50 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Fri Jul 24 07:02:50 2020] 127.0.0.1:38412 [401]: /remote.php/webdav/myFileToTag.txt
[Fri Jul 24 07:02:50 2020] 127.0.0.1:38414 [404]: /remote.php/dav/addressbooks/users/admin/MyAddressbook
[Fri Jul 24 07:02:50 2020] 127.0.0.1:38426 [404]: /remote.php/dav/calendars/admin/MyCalendar

acceptance-app-files

• tests/acceptance/features/app-files.feature:108

Show full log

  Scenario: show shares                                               # /drone/src/tests/acceptance/features/app-files.feature:108
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                            # FilesAppSharingContext::iShareTheLinkFor()
    When I open the "Shares" section                                  # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Shares"                   # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

[rullzer]

Noice