Skip to content

reset the cookie internally in new API when abandoning paged results op #22043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Jul 31, 2020
Merged

reset the cookie internally in new API when abandoning paged results op #22043

MorrisJobke merged 1 commit into from
Jul 31, 2020

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Jul 29, 2020 •
edited
Loading

Fixes #21892

Reproduction steps:

  1. Have Active Directory configured (not OpenLDAP, Samba4 or others), with a small Cache TTL
  2. Have all LDAP users mapped
  3. Delete a known user
  4. run php occ ldap:check-user USERID

Before the fix, an LDAP Error ("LDAP error Critical extension is unavailable (12) after calling ldap_search" ) was logged.

(Note: there are other ways to get this error, the described steps are the easiest and most reliable way to trigger it).

@blizzz blizzz added this to the Nextcloud 20 milestone Jul 29, 2020
@blizzz
Copy link
Member Author

blizzz commented Jul 29, 2020

/backport to stable19

@blizzz blizzz mentioned this pull request Jul 29, 2020
Closed
@blizzz
reset the cookie internally in new API when abandoning paged results op
d3501be 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the fix/21892/reset-internal-cookie-state branch from 4825ca4 to d3501be Compare July 29, 2020 15:49
@faily-bot

This comment has been minimized.

Sign in to view
MorrisJobke
MorrisJobke approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 31, 2020
@MorrisJobke MorrisJobke merged commit 21095be into master Jul 31, 2020
@MorrisJobke MorrisJobke deleted the fix/21892/reset-internal-cookie-state branch July 31, 2020 08:14
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@bfritscher bfritscher Awaiting requested review from bfritscher

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@kklem0 kklem0 Awaiting requested review from kklem0

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: ldap

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

ldap_search(): Search : Critical extension is unavailable on v19.0.0

4 participants

@blizzz @MorrisJobke @juliusknorr