-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add settings sections to unified search #22095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settings sections to unified search #22095
Conversation
nickvergessen
commented
Aug 3, 2020

Signed-off-by: Joas Schilling <coding@schilljs.com>
|
|
||
| use OCP\Search\ASearchResultEntry; | ||
|
|
||
| class SectionResult extends ASearchResultEntry { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All those empty files start to bother me already. Should just make the ASearchResultEntry class non-abstract :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nickvergessen please do :)
|
The icons are still black when using dark-theme. |
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 31324: failureacceptance-app-files-sharing
Show full log |
jancborchardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeeeeah, really really cool! :) Finally a start of search in settings.
…ns-in-unified-search Add settings sections to unified search