App navigation via unified search

[nickvergessen]

Branch targets #22099

[nickvergessen]

Rebased with order adjustments

[skjnldsv]

Btw, is there no other way for an API to have empty strings like that? Is that good practices?

[jancborchardt]

Looks good! 👍 to @skjnldsv’s feedback, and also I found one entry which doesn’t really make sense – there’s possibly more which we might need to filter?

[jancborchardt]

My feedback can also be fixed in a follow-up tho.

[nickvergessen]

there’s possibly more which we might need to filter?

Well user status is registering a navigation link which is highjacked by JS. I'm not aware we have more of this, but now fixed by ignoring empty link items

Fix both issues.

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31430: failure

acceptance-app-files

• tests/acceptance/features/app-files.feature:262

Show full log

  Scenario: unmarking a file as favorite causes the file list to be sorted again                          # /drone/src/tests/acceptance/features/app-files.feature:262
    Given I am logged in                                                                                  # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "A name alphabetically lower than welcome.txt"                        # FileListContext::iCreateANewFolderNamed()
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    And I close the details view                                                                          # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                             # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I mark "welcome.txt" as favorite                                                                  # FileListContext::iMarkAsFavorite()
    And I see that "welcome.txt" is marked as favorite                                                    # FileListContext::iSeeThatIsMarkedAsFavorite()
    And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    When I unmark "welcome.txt" as favorite                                                               # FileListContext::iUnmarkAsFavorite()
    Then I see that "welcome.txt" is not marked as favorite                                               # FileListContext::iSeeThatIsNotMarkedAsFavorite()
      Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

[MorrisJobke]

How nice is this?!? :) I love it already 👍