Skip to content

[stable19] Fix empty 'more' apps navigation after installing an app #22183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Aug 11, 2020
Merged

[stable19] Fix empty 'more' apps navigation after installing an app #22183

rullzer merged 1 commit into from
Aug 11, 2020

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Aug 11, 2020

backport of #21173

@jancborchardt @backportbot
Fix empty 'more' apps navigation after installing an app
53d9975 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 19.0.2 milestone Aug 11, 2020
@rullzer rullzer added the 3. to review Waiting for reviews label Aug 11, 2020
@faily-bot
Copy link

faily-bot bot commented Aug 11, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31607: failure

mariadb10.1-php7.2

Show full log 
There was 1 failure:

1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'

/drone/src/apps/files_versions/tests/VersioningTest.php:730

mariadb10.4-php7.3

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

@rullzer rullzer merged commit eded52e into stable19 Aug 11, 2020
@rullzer rullzer deleted the backport/21173/stable19 branch August 11, 2020 18:25
@rullzer rullzer mentioned this pull request Aug 13, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@georgehrke georgehrke Awaiting requested review from georgehrke

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@kesselb kesselb Awaiting requested review from kesselb

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: apps management

Projects

None yet

Milestone

Nextcloud 19.0.2

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer @skjnldsv @jancborchardt