Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #22196

Do not blind concatenate ints. Lets add a _ between them. So that we can
distrinquis them properly

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added the 3. to review Waiting for reviews label Aug 12, 2020
@faily-bot
Copy link

faily-bot bot commented Aug 12, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31676: failure

webpack-build

mysql8.0-php7.2

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

integration-sharing-v1

  • build/integration/features/sharing-v1.feature:58
Show full log
  Scenario: Creating a new mail share        # /drone/src/build/integration/features/sharing-v1.feature:58
    Given dummy mail server is listening     # FeatureContext::dummyMailServerIsListening()
[Wed Aug 12 08:01:25 2020] 127.0.0.1:38206 [404]: /ocs/v2.php/cloud/users/user0
[Wed Aug 12 08:01:25 2020] 127.0.0.1:38214 [200]: /ocs/v1.php/cloud/users
[Wed Aug 12 08:01:25 2020] 127.0.0.1:38240 [200]: /ocs/v1.php/cloud/users/user0
[Wed Aug 12 08:01:25 2020] 127.0.0.1:38272 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                  # FeatureContext::assureUserExists()
    And As an "user0"                        # FeatureContext::asAn()
[Wed Aug 12 08:01:25 2020] {"Exception":"Swift_TransportException","Message":"Connection could not be established with host 127.0.0.1 [Connection refused #111]","Code":0,"Trace":[{"file":"\/drone\/src\/3rdparty\/swiftmailer\/swiftmailer\/lib\/classes\/Swift\/Transport\/StreamBuffer.php","line":58,"function":"establishSocketConnection","class":"Swift_Transport_StreamBuffer","type":"->","args":[]},{"file":"\/drone\/src\/3rdparty\/swiftmailer\/swiftmailer\/lib\/classes\/Swift\/Transport\/AbstractSmtpTransport.php","line":143,"function":"initialize","class":"Swift_Transport_StreamBuffer","type":"->","args":[{"protocol":"","host":"127.0.0.1","port":25,"timeout":10,"blocking":1,"tls":false,"type":1,"stream_context_options":[]}]},{"file":"\/drone\/src\/3rdparty\/swiftmailer\/swiftmailer\/lib\/classes\/Swift\/Mailer.php","line":65,"function":"start","class":"Swift_Transport_AbstractSmtpTransport","type":"->","args":[]},{"file":"\/drone\/src\/lib\/private\/Mail\/Mailer.php","line":185,"function":"send","class":"Swift_Mailer","type":"->","args":[{"__class__":"Swift_Message"},[]]},{"file":"\/drone\/src\/apps\/sharebymail\/lib\/ShareByMailProvider.php","line":444,"function":"send","class":"OC\\Mail\\Mailer","type":"->","args":[{"__class__":"OC\\Mail\\Message"}]},{"file":"\/drone\/src\/apps\/sharebymail\/lib\/ShareByMailProvider.php","line":356,"function":"sendMailNotification","class":"OCA\\ShareByMail\\ShareByMailProvider","type":"->","args":["welcome.txt","http:\/\/localhost:8080\/index.php\/s\/j27wLkpxa2nM57f","user0","dumy@test.com",null]},{"file":"\/drone\/src\/apps\/sharebymail\/lib\/ShareByMailProvider.php","line":186,"function":"createMailShare","class":"OCA\\ShareByMail\\ShareByMailProvider","type":"->","args":[{"__class__":"OC\\Share20\\Share"}]},{"file":"\/drone\/src\/lib\/private\/Share20\/Manager.php","line":700,"function":"create","class":"OCA\\ShareByMail\\ShareByMailProvider","type":"->","args":[{"__class__":"OC\\Share20\\Share"}]},{"file":"\/drone\/src\/apps\/files_sharing\/lib\/Controller\/ShareAPIController.php","line":577,"function":"createShare","class":"OC\\Share20\\Manager","type":"->","args":[{"__class__":"OC\\Share20\\Share"}]},{"file":"\/drone\/src\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":170,"function":"createShare","class":"OCA\\Files_Sharing\\Controller\\ShareAPIController","type":"->","args":[{"__class__":"OC\\Files\\Node\\File"},19,4,"dumy@test.com","false","",null,"",""]},{"file":"\/drone\/src\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":99,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Files_Sharing\\Controller\\ShareAPIController"},"createShare"]},{"file":"\/drone\/src\/lib\/private\/AppFramework\/App.php","line":126,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[{"__class__":"OCA\\Files_Sharing\\Controller\\ShareAPIController"},"createShare"]},{"file":"\/drone\/src\/lib\/private\/AppFramework\/Routing\/RouteActionHandler.php","line":47,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Files_Sharing\\Controller\\ShareAPIController","createShare",{"__class__":"OC\\AppFramework\\DependencyInjection\\DIContainer"},{"_route":"ocs.files_sharing.ShareAPI.createShare"}]},{"function":"__invoke","class":"OC\\AppFramework\\Routing\\RouteActionHandler","type":"->","args":[{"_route":"ocs.files_sharing.ShareAPI.createShare"}]},{"file":"\/drone\/src\/lib\/private\/Route\/Router.php","line":297,"function":"call_user_func","args":[{"__class__":"OC\\AppFramework\\Routing\\RouteActionHandler"},{"_route":"ocs.files_sharing.ShareAPI.createShare"}]},{"file":"\/drone\/src\/ocs\/v1.php","line":82,"function":"match","class":"OC\\Route\\Router","type":"->","args":["\/ocsapp\/apps\/files_sharing\/api\/v1\/shares"]}],"File":"\/drone\/src\/3rdparty\/swiftmailer\/swiftmailer\/lib\/classes\/Swift\/Transport\/StreamBuffer.php","Line":269,"CustomMessage":"Failed to send share by mail."}
[Wed Aug 12 08:01:25 2020] 127.0.0.1:38288 [401]: /ocs/v1.php/apps/files_sharing/api/v1/shares
    When creating a share with               # FeatureContext::creatingShare()
      | path      | welcome.txt   |
      | shareType | 4             |
      | shareWith | dumy@test.com |
    Then the OCS status code should be "100" # FeatureContext::theOCSStatusCodeShouldBe()
      Failed asserting that SimpleXMLElement Object &000000000dc328aa000000007249d153 (
          0 => '403'
      ) matches expected '100'.
    And the HTTP status code should be "200" # FeatureContext::theHTTPStatusCodeShouldBe()
    And last share can be downloaded         # FeatureContext::lastShareCanBeDownloaded()
[Wed Aug 12 08:01:26 2020] 127.0.0.1:38368 [200]: /ocs/v1.php/cloud/users/user0
[Wed Aug 12 08:01:26 2020] 127.0.0.1:38386 [404]: /ocs/v2.php/cloud/users/user0
[Wed Aug 12 08:01:26 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Wed Aug 12 08:01:26 2020] 127.0.0.1:38396 [401]: /remote.php/webdav/myFileToComment.txt
[Wed Aug 12 08:01:26 2020] 127.0.0.1:38400 [207]: /remote.php/dav/systemtags/
[Wed Aug 12 08:01:26 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Wed Aug 12 08:01:26 2020] 127.0.0.1:38410 [401]: /remote.php/webdav/myFileToTag.txt
[Wed Aug 12 08:01:26 2020] 127.0.0.1:38412 [404]: /remote.php/dav/addressbooks/users/admin/MyAddressbook
[Wed Aug 12 08:01:26 2020] 127.0.0.1:38422 [404]: /remote.php/dav/calendars/admin/MyCalendar

@MorrisJobke MorrisJobke merged commit 9f51097 into stable17 Aug 12, 2020
@MorrisJobke MorrisJobke deleted the backport/22196/stable17 branch August 12, 2020 12:26
@rullzer rullzer mentioned this pull request Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants