Skip to content

[stable19] provide event class and typed event to LDAP loaded event; also fixing a logged deprecation message #22254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
backportbot-nextcloud wants to merge 1 commit into from
Closed

[stable19] provide event class and typed event to LDAP loaded event; also fixing a logged deprecation message #22254

backportbot-nextcloud wants to merge 1 commit into from

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Aug 14, 2020 •
edited
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #22221

@blizzz @backportbot
provide event class to LDAP loaded event to fix deprecation message
8b7d08d 
* and also dispatch the typed event as current approach to it

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 19.0.2 milestone Aug 14, 2020
@MorrisJobke
Copy link
Member

MorrisJobke commented Aug 14, 2020

⚠️ This backport had conflicts and is incomplete ⚠️

@blizzz Mind to look into them?

@faily-bot
Copy link

faily-bot bot commented Aug 14, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31808: failure

integration-provisioning-v2

  • build/integration/features/provisioning-v2.feature:22
Show full log 
  Scenario: Searching by displayname in groups                                                    # /drone/src/build/integration/features/provisioning-v2.feature:22
    Given As an "admin"                                                                           # FeatureContext::asAn()
[Fri Aug 14 14:47:34 2020] 127.0.0.1:51472 [404]: /ocs/v2.php/cloud/users/user-in-group
[Fri Aug 14 14:47:35 2020] 127.0.0.1:51500 [200]: /ocs/v2.php/cloud/users
[Fri Aug 14 14:47:35 2020] 127.0.0.1:51604 [200]: /ocs/v2.php/cloud/users/user-in-group
[Fri Aug 14 14:47:35 2020] 127.0.0.1:51640 [200]: /ocs/v2.php/cloud/users/user-in-group
    And user "user-in-group" with displayname "specific-name" exists                              # FeatureContext::assureUserWithDisplaynameExists()
[Fri Aug 14 14:47:36 2020] 127.0.0.1:51680 [404]: /ocs/v2.php/cloud/users/user-in-group2
[Fri Aug 14 14:47:36 2020] 127.0.0.1:51704 [200]: /ocs/v2.php/cloud/users
[Fri Aug 14 14:47:37 2020] 127.0.0.1:51784 [200]: /ocs/v2.php/cloud/users/user-in-group2
[Fri Aug 14 14:47:37 2020] 127.0.0.1:51828 [200]: /ocs/v2.php/cloud/users/user-in-group2
    And user "user-in-group2" with displayname "another-name" exists                              # FeatureContext::assureUserWithDisplaynameExists()
[Fri Aug 14 14:47:37 2020] 127.0.0.1:51864 [404]: /ocs/v2.php/cloud/users/user-not-in-group
[Fri Aug 14 14:47:38 2020] 127.0.0.1:51896 [200]: /ocs/v2.php/cloud/users
[Fri Aug 14 14:47:38 2020] 127.0.0.1:52006 [200]: /ocs/v2.php/cloud/users/user-not-in-group
[Fri Aug 14 14:47:38 2020] 127.0.0.1:52056 [200]: /ocs/v2.php/cloud/users/user-not-in-group
    And user "user-not-in-group" with displayname "specific-name" exists                          # FeatureContext::assureUserWithDisplaynameExists()
[Fri Aug 14 14:47:39 2020] 127.0.0.1:52092 [404]: /ocs/v2.php/cloud/users/user-not-in-group2
[Fri Aug 14 14:47:39 2020] 127.0.0.1:52126 [200]: /ocs/v2.php/cloud/users
[Fri Aug 14 14:47:40 2020] 127.0.0.1:52218 [200]: /ocs/v2.php/cloud/users/user-not-in-group2
[Fri Aug 14 14:47:40 2020] 127.0.0.1:52262 [200]: /ocs/v2.php/cloud/users/user-not-in-group2
    And user "user-not-in-group2" with displayname "another-name" exists                          # FeatureContext::assureUserWithDisplaynameExists()
[Fri Aug 14 14:47:40 2020] 127.0.0.1:52288 [404]: /ocs/v2.php/cloud/groups/group-search
[Fri Aug 14 14:47:40 2020] 127.0.0.1:52314 [200]: /ocs/v2.php/cloud/groups
[Fri Aug 14 14:47:41 2020] 127.0.0.1:52342 [200]: /ocs/v2.php/cloud/groups/group-search
    And group "group-search" exists                                                               # FeatureContext::assureGroupExists()
[Fri Aug 14 14:47:41 2020] 127.0.0.1:52368 [200]: /ocs/v2.php/cloud/users/user-in-group/groups
[Fri Aug 14 14:47:41 2020] 127.0.0.1:52394 [200]: /ocs/v2.php/cloud/users/user-in-group/groups
[Fri Aug 14 14:47:41 2020] 127.0.0.1:52422 [200]: /ocs/v2.php/cloud/users/user-in-group/groups
    And user "user-in-group" belongs to group "group-search"                                      # FeatureContext::assureUserBelongsToGroup()
[Fri Aug 14 14:47:42 2020] 127.0.0.1:52446 [200]: /ocs/v2.php/cloud/users/user-in-group2/groups
[Fri Aug 14 14:47:42 2020] 127.0.0.1:52476 [200]: /ocs/v2.php/cloud/users/user-in-group2/groups
[Fri Aug 14 14:47:42 2020] 127.0.0.1:52504 [200]: /ocs/v2.php/cloud/users/user-in-group2/groups
    And user "user-in-group2" belongs to group "group-search"                                     # FeatureContext::assureUserBelongsToGroup()
[Fri Aug 14 14:47:42 2020] 127.0.0.1:52544 [200]: /ocs/v2.php/cloud/groups/group-search/users/details?offset=0&limit=25&search=ifi
    When sending "GET" to "/cloud/groups/group-search/users/details?offset=0&limit=25&search=ifi" # FeatureContext::sendingTo()
    Then the OCS status code should be "200"                                                      # FeatureContext::theOCSStatusCodeShouldBe()
    And the HTTP status code should be "200"                                                      # FeatureContext::theHTTPStatusCodeShouldBe()
    And detailed users returned are                                                               # FeatureContext::theDetailedUsersShouldBe()
      | user-in-group |
      Failed asserting that two arrays are equal.
      --- Expected
      +++ Actual
      @@ @@
       Array (
      -    0 => 'user-in-group'
[Fri Aug 14 14:47:43 2020] 127.0.0.1:52570 [200]: /ocs/v2.php/cloud/users/user-in-group
[Fri Aug 14 14:47:43 2020] 127.0.0.1:52604 [404]: /ocs/v2.php/cloud/users/user-in-group
[Fri Aug 14 14:47:43 2020] 127.0.0.1:52632 [200]: /ocs/v2.php/cloud/users/user-in-group2
[Fri Aug 14 14:47:44 2020] 127.0.0.1:52680 [404]: /ocs/v2.php/cloud/users/user-in-group2
[Fri Aug 14 14:47:44 2020] 127.0.0.1:52712 [200]: /ocs/v2.php/cloud/users/user-not-in-group
[Fri Aug 14 14:47:45 2020] 127.0.0.1:52766 [404]: /ocs/v2.php/cloud/users/user-not-in-group
[Fri Aug 14 14:47:45 2020] 127.0.0.1:52808 [200]: /ocs/v2.php/cloud/users/user-not-in-group2
[Fri Aug 14 14:47:45 2020] 127.0.0.1:52850 [404]: /ocs/v2.php/cloud/users/user-not-in-group2
[Fri Aug 14 14:47:45 2020] 127.0.0.1:52876 [200]: /ocs/v2.php/cloud/groups/group-search
[Fri Aug 14 14:47:46 2020] 127.0.0.1:52926 [404]: /ocs/v2.php/cloud/groups/group-search
[Fri Aug 14 14:47:46 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Fri Aug 14 14:47:46 2020] 127.0.0.1:52950 [401]: /remote.php/webdav/myFileToComment.txt
[Fri Aug 14 14:47:46 2020] 127.0.0.1:52954 [207]: /remote.php/dav/systemtags/
[Fri Aug 14 14:47:46 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Fri Aug 14 14:47:46 2020] 127.0.0.1:52978 [401]: /remote.php/webdav/myFileToTag.txt
[Fri Aug 14 14:47:46 2020] 127.0.0.1:52990 [404]: /remote.php/dav/addressbooks/users/admin/MyAddressbook
[Fri Aug 14 14:47:46 2020] 127.0.0.1:53038 [404]: /remote.php/dav/calendars/admin/MyCalendar

@rullzer rullzer added the 3. to review Waiting for reviews label Aug 17, 2020
@rullzer rullzer mentioned this pull request Aug 18, 2020
Merged
1 task
@MorrisJobke
Copy link
Member

MorrisJobke commented Aug 19, 2020

log problems only -> move to 19.0.3

@blizzz blizzz mentioned this pull request Aug 19, 2020
Merged
@blizzz
Copy link
Member

blizzz commented Aug 19, 2020

simplified backport in #22309

@blizzz blizzz closed this Aug 19, 2020
@blizzz blizzz deleted the backport/22221/stable19 branch August 19, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz Awaiting requested review from blizzz

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@rullzer rullzer Awaiting requested review from rullzer

@viniciuscb viniciuscb Awaiting requested review from viniciuscb

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: ldap technical debt

Projects

None yet

Milestone

Nextcloud 19.0.3

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke @blizzz @rullzer