Some more Dashboard design polishing

[jancborchardt]

Quick review @juliushaertl @eneiluj

• Move widget headings to more semantically correct h2 (since widget entries can contain h3)
• Adjust design of 'Get more widgets' button (more padding)
• Fix text on background choices (was too far down, not vertically centered)
• Suppress scrollbar inside widgets

[julien-nc]

Move widget headings to more semantically correct h2 (since widget entries can contain h3)

Yes.

Adjust design of 'Get more widgets' button (more padding)

Yes.

Fix text on background choices (was too far down, not vertically centered)

Yyyyes. Didn't even notice that...

All good!

Any clue on how to fix the statuses color when menu open and hovering the items?

[jancborchardt]

Also added a commit to suppress any scrollbars inside widgets. I’m seeing one in the Mail widget since nextcloud/mail#3460 it seems – any idea @juliushaertl?

[jancborchardt]

Any clue on how to fix the statuses color when menu open and hovering the items?

Fixed that one now too, ready to review – or anything else? :)

[julien-nc]

Very nice!

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32116: failure

mariadb10.4-php7.3

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\MoveFromCacheTraitTest::testBogusPaths with data set #1 ('//bogus.txt', 'bogus.txt')
Failed asserting that 0 is greater than 0.

/drone/src/tests/lib/Files/Cache/CacheTest.php:631

postgres9-php7.3

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'

/drone/src/apps/files_versions/tests/VersioningTest.php:729

acceptance-app-files

• tests/acceptance/features/app-files.feature:262

Show full log

  Scenario: unmarking a file as favorite causes the file list to be sorted again                          # /drone/src/tests/acceptance/features/app-files.feature:262
    Given I am logged in                                                                                  # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "A name alphabetically lower than welcome.txt"                        # FileListContext::iCreateANewFolderNamed()
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    And I close the details view                                                                          # FilesAppContext::iCloseTheDetailsView()
    And I see that the details view is closed                                                             # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
    And I mark "welcome.txt" as favorite                                                                  # FileListContext::iMarkAsFavorite()
    And I see that "welcome.txt" is marked as favorite                                                    # FileListContext::iSeeThatIsMarkedAsFavorite()
    And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
    When I unmark "welcome.txt" as favorite                                                               # FileListContext::iUnmarkAsFavorite()
    Then I see that "welcome.txt" is not marked as favorite                                               # FileListContext::iSeeThatIsNotMarkedAsFavorite()
      Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
    And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

acceptance-users

• tests/acceptance/features/users.feature:128

Show full log

  Scenario: change password                                         # /drone/src/tests/acceptance/features/users.feature:128
    Given I act as Jane                                             # ActorContext::iActAs()
    And I am logged in as the admin                                 # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                    # SettingsMenuContext::iOpenTheUserSettings()
    And I see that the list of users contains the user user0        # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    When I toggle the edit mode for the user user0                  # UsersSettingsContext::iToggleTheEditModeForUser()
    Then I see that the edit mode is on for user user0              # UsersSettingsContext::iSeeThatTheEditModeIsOn()
    And I see that the password of user0 is ""                      # UsersSettingsContext::iSeeThatTheFieldOfUserIs()
    When I set the password for user0 to 123456                     # UsersSettingsContext::iSetTheFieldForUserTo()
    And I see that the password cell for user user0 is done loading # UsersSettingsContext::iSeeThatTheCellForUserIsDoneLoading()
    Then I see that the password of user0 is ""                     # UsersSettingsContext::iSeeThatTheFieldOfUserIs()
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -'123456'
      +''

[juliusknorr]

/compile amend /

[MorrisJobke]

Psalm warning is fixed with #22345