Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 7, 2020

Currently this auto merge patch releases.

While I think it's fine to auto-merge minor on other apps.
I'd be more cautious on server

cc @nextcloud/javascript

Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependabot.yml is missing plenty of our current config:
49244B25-F351-48D6-A810-F540FF9CC808

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 7, 2020

Done @georgehrke !
I think it doesn't make sense to keep upgrading npm in /build for stablexx versions.
Testui integration has been removed from master now and is outdated.

@skjnldsv skjnldsv requested a review from georgehrke September 7, 2020 12:47
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 7, 2020

Hum, actually, do we want to keep upgrading /build/integration for stablexx branches?
I would only upgrade main npm to be honest

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 7, 2020

Capture d’écran_2020-09-07_14-56-08
Damnit

EDIT: dependabot/dependabot-core#2159 (comment)

@faily-bot
Copy link

faily-bot bot commented Sep 7, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32756: failure

acceptance-app-files-sharing

  • tests/acceptance/features/app-files-sharing.feature:338
Show full log
  Scenario: sharee can revoke create permission from reshare after the sharer disabled it # /drone/src/tests/acceptance/features/app-files-sharing.feature:338
    Given I act as John                                                                   # ActorContext::iActAs()
    And I am logged in as the admin                                                       # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I act as Jane                                                                     # ActorContext::iActAs()
    And I am logged in                                                                    # LoginPageContext::iAmLoggedIn()
    And I act as Jim                                                                      # ActorContext::iActAs()
    And I am logged in as "user1"                                                         # LoginPageContext::iAmLoggedInAs()
    And I act as John                                                                     # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                                       # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"                    # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "Shared folder" with "user0"                                              # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                                        # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                                     # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I share "Shared folder" with "user1"                                              # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user1"                                        # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as John                                                                     # ActorContext::iActAs()
    And I set the share with "user0" as not creatable                                     # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
    And I see that "user0" can not create in the share                                    # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
    And I act as Jim                                                                      # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Shared folder"                                       # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Subfolder"                                           # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Subfolder"                        # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I act as Jane                                                                    # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I open the details view for "Shared folder"                                       # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                               # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                                      # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded             # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I set the share with "user1" as not creatable                                     # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
    Then I see that "user1" can not create in the share                                   # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
    And I see that "user1" can not be allowed to create in the share                      # FilesAppSharingContext::iSeeThatCanNotBeAllowedToCreateInTheShare()
    And I act as Jim                                                                      # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Shared folder"                                       # FileListContext::iEnterInTheFolderNamed()
    And I see that it is not possible to create new files                                 # FileListContext::iSeeThatItIsNotPossibleToCreateNewFiles()
      Failed asserting that true is false.

Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but i can't judge the part regarding the integration test suite.

@juliusknorr
Copy link
Member

Hum, actually, do we want to keep upgrading /build/integration for stablexx branches?

Yeah just security updates i'd say for those.

We can just adjust the string of the branches when backporting the dependabot config to the stable branches.

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 8, 2020

Yeah just security updates i'd say for those.

We can just adjust the string of the branches when backporting the dependabot config to the stable branches.

No, because dependabot doesn't check other branches than master
So we need to adjust master only.
Regarding security updates, I think they follow an independent release process. So it doesn't matter rather we have a dependabot config or not as long as it's enabled in https://github.com/nextcloud/server/network/alerts & https://github.com/nextcloud/server/settings/security_analysis

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 8, 2020
@skjnldsv skjnldsv merged commit 90b1244 into master Sep 8, 2020
@skjnldsv skjnldsv deleted the dependabot/config branch September 8, 2020 06:36
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 8, 2020

@rullzer rullzer mentioned this pull request Sep 8, 2020
13 tasks
@skjnldsv skjnldsv restored the dependabot/config branch May 26, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants