[stable9] Move OC_Channel to system config #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Usage can be seen at nextcloud/updater#20, with that also daily builds etc. are not a problem anymore |
Member
|
Code looks good, haven't tested yet |
Member
|
Tested and works 👍 The version number needs to be increased to invoke the repair step, but this will be done during the release anyway ;) |
The Nextcloud and ownCloud updaters allow someone to configure a custom release channel, this can then be used to publish different versions. (e.g. one channel stays on 9.x while another one already gets 10.x) There is however one big problem with it: The value is effectively stored in the app config, which is stored in the database. So to be able to read the update channel a connection to the database is necessary. This is quite error prone and also causes some of the issues in the original ownCloud updater. This moves the channel registration to the config.php and also includes a repair step.
MorrisJobke
force-pushed
the
stable9-channel-should-be-inside-config
branch
from
e7b41be to
9f7141d
Compare
Member
|
Rebased to resolve a conflict in the config.sample.php |
Member
Author
|
LGTM |
Member
|
Why is self approval working 😱 we have disabled it in LGTM 😕 |
Member
We have no idea 😕 |
Member
|
I have 😅 #238 @MorrisJobke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Nextcloud and ownCloud updaters allow someone to configure a custom release channel, this can then be used to publish different versions. (e.g. one channel stays on 9.x while another one already gets 10.x)
There is however one big problem with it: The value is effectively stored in the app config, which is stored in the database. So to be able to read the update channel a connection to the database is necessary. This is quite error prone and also causes some of the issues in the original ownCloud updater.
This moves the channel registration to the config.php and also includes a repair step.
@MorrisJobke Mind taking a look?