Skip to content

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Nov 24, 2016

Sometimes oc_mount entries can be in the table for non existing users

Fixes #2297

Signed-off-by: Robin Appelman <robin@icewind.nl>
@mention-bot
Copy link

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @nickvergessen and @LukasReschke to be potential reviewers.

@LukasReschke
Copy link
Member

Can we add a unit test for that?

Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks stuff. 👎

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Nov 24, 2016
@icewind1991 icewind1991 added this to the Nextcloud 11.0 milestone Nov 24, 2016
@icewind1991
Copy link
Member Author

icewind1991 commented Nov 24, 2016

@LukasReschke breakage you discovered was caused by a separate issue

@rullzer @MorrisJobke please review

@LukasReschke
Copy link
Member

@LukasReschke breakage you discovered was caused by a separate issue

Do we have somebody working on that issue? 😉

@icewind1991
Copy link
Member Author

Do we have somebody working on that issue?

There was a problem with mounts not being registered for users, while debugging I noticed the files_sharing app being disable (no idea how, for how long or why), after re-enabling it everything works again

@jospoortvliet
Copy link
Member

Hmmm if that breaks stuff perhaps it should not be something that can be disabled... because I bet we don't test that.

@icewind1991
Copy link
Member Author

Hmmm if that breaks stuff

"Disabling sharing breaks shares", more at 11

😄

@jospoortvliet
Copy link
Member

Hehe ok thought it broke much more than shares. If just shares then fine, that is obvious.

Still a question how it got disabled, did the updater do that?

@MorrisJobke
Copy link
Member

Tested and works with existing setup 👍

@LukasReschke
Copy link
Member

LukasReschke commented Nov 24, 2016

Hehe ok thought it broke much more than shares. If just shares then fine, that is obvious.
Still a question how it got disabled, did the updater do that?

We have to have that fixed before we can do any beta or so. @icewind1991 can you try to reproduce the update situation on clonecloud or so? I also could offer an pre-update MySQL dump of the original instance.

I just did a regular update with replacing files and that's it…

@LukasReschke
Copy link
Member

LGTM

@LukasReschke LukasReschke merged commit d6ade50 into master Nov 24, 2016
@LukasReschke LukasReschke deleted the oc-mounts-non-existing-user branch November 24, 2016 14:28
@blizzz
Copy link
Member

blizzz commented Dec 7, 2016

On a test upgrade against an instance with my production data, file_sharing was kept active after the update.

However, due to a the mysterious Webserver needs restart after upgrade – which I did not do – it caused theming to fail, because some old pathes where cached (PHP internal). Only Theming was affected though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants