-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
filter out oc_mounts results from non existing users #2299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
|
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @nickvergessen and @LukasReschke to be potential reviewers. |
|
Can we add a unit test for that? |
LukasReschke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaks stuff. 👎
|
@LukasReschke breakage you discovered was caused by a separate issue @rullzer @MorrisJobke please review |
Do we have somebody working on that issue? 😉 |
There was a problem with mounts not being registered for users, while debugging I noticed the files_sharing app being disable (no idea how, for how long or why), after re-enabling it everything works again |
|
Hmmm if that breaks stuff perhaps it should not be something that can be disabled... because I bet we don't test that. |
"Disabling sharing breaks shares", more at 11 😄 |
|
Hehe ok thought it broke much more than shares. If just shares then fine, that is obvious. Still a question how it got disabled, did the updater do that? |
|
Tested and works with existing setup 👍 |
We have to have that fixed before we can do any beta or so. @icewind1991 can you try to reproduce the update situation on clonecloud or so? I also could offer an pre-update MySQL dump of the original instance. I just did a regular update with replacing files and that's it… |
|
LGTM |
|
On a test upgrade against an instance with my production data, file_sharing was kept active after the update. However, due to a the mysterious |
Sometimes oc_mount entries can be in the table for non existing users
Fixes #2297