-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add to README about compiling JS production assets. #23306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add note in README about the need to checkin also compiled JS assets after running `make build-js-production`. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
skjnldsv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
|
Add a note about |
Added hint about MODULE=xxx when recompiling production assets. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
|
I've added a commit with the "MODULE" hint @nickvergessen |
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 33905: failuresqliteShow full logmariadb10.1-php7.3
mariadb10.4-php7.4
mysql8.0-php7.4
mysql5.6-php7.3
postgres9-php7.3Show full logpostgres11-php7.4
|
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Add note in README about the need to checkin also compiled JS assets
after running
make build-js-production.I hope this is correct... I interpreted this by looking at other PRs containing JS assets.