Skip to content

Conversation

@PVince81
Copy link
Member

@PVince81 PVince81 commented Oct 9, 2020

Add note in README about the need to checkin also compiled JS assets
after running make build-js-production.

I hope this is correct... I interpreted this by looking at other PRs containing JS assets.

Add note in README about the need to checkin also compiled JS assets
after running `make build-js-production`.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@nickvergessen
Copy link
Member

Add a note about MODULE=user_status make build-js-production ?

@skjnldsv skjnldsv added 3. to review Waiting for reviews enhancement labels Oct 9, 2020
Added hint about MODULE=xxx when recompiling production assets.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81
Copy link
Member Author

PVince81 commented Oct 9, 2020

I've added a commit with the "MODULE" hint @nickvergessen

@faily-bot
Copy link

faily-bot bot commented Oct 9, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33905: failure

sqlite

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) TrashbinTest::testExpireOldFilesShared
Failed asserting that 3 is identical to 2.

/drone/src/apps/files_trashbin/tests/TrashbinTest.php:304
/drone/src/apps/files_trashbin/tests/TrashbinTest.php:287

mariadb10.1-php7.3

mariadb10.4-php7.4

mysql8.0-php7.4

mysql5.6-php7.3

postgres9-php7.3

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) TrashbinTest::testExpireOldFilesShared
Failed asserting that 3 is identical to 2.

/drone/src/apps/files_trashbin/tests/TrashbinTest.php:304
/drone/src/apps/files_trashbin/tests/TrashbinTest.php:287

postgres11-php7.4

@juliusknorr juliusknorr merged commit ef6bab6 into master Oct 12, 2020
@juliusknorr juliusknorr deleted the update-readme-compiled-commits branch October 12, 2020 07:13
@welcome
Copy link

welcome bot commented Oct 12, 2020

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants