Skip to content

Conversation

@skjnldsv
Copy link
Member

  • Prevent submitting empty messages
  • Fix white-spacing
  • Hide long messages like it was before (click to unroll)
  • Fix undo timeout by bumping the nextcloud dialogs
  • Add mentions data
    Capture d’écran_2020-10-21_16-29-51

Follow-up #23173

@skjnldsv
Copy link
Member Author

/compile /

@blizzz
Copy link
Member

blizzz commented Oct 22, 2020

from the screenshots, does it fix a bug where the display name was not shown, or does it now show the internal user id?

@skjnldsv
Copy link
Member Author

from the screenshots, does it fix a bug where the display name was not shown, or does it now show the internal user id?

I have no idea what bug you are refering to. We're now using the data provided by the comments>mentions dav properties. SO it should render as it used to :)

@blizzz
Copy link
Member

blizzz commented Oct 22, 2020

from the screenshots, does it fix a bug where the display name was not shown, or does it now show the internal user id?

I have no idea what bug you are refering to. We're now using the data provided by the comments>mentions dav properties. SO it should render as it used to :)

I think I misinterpreted the screenshot from the description. Never mind :)

@skjnldsv skjnldsv force-pushed the fix/comments/various branch from c11f253 to f09dff5 Compare October 23, 2020 12:42
@skjnldsv skjnldsv force-pushed the fix/comments/various branch from f09dff5 to 49b75a5 Compare October 27, 2020 19:02
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 27, 2020
@skjnldsv
Copy link
Member Author

/compile amend /

1 similar comment
@skjnldsv
Copy link
Member Author

/compile amend /

@skjnldsv skjnldsv force-pushed the fix/comments/various branch 2 times, most recently from 365b757 to 3b279d0 Compare October 28, 2020 09:25
@skjnldsv
Copy link
Member Author

Jsunit tests fixed

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/comments/various branch from 3b279d0 to 34100f1 Compare October 28, 2020 09:28
@faily-bot
Copy link

faily-bot bot commented Oct 28, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34676: failure

mysql8.0-php7.4

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testGroupDeleted with data set #3 (array(1, 'group1', array('foo', 'bar')), 'group2', false)
Failed asserting that actual size 2 matches expected size 3.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:2418

@skjnldsv skjnldsv merged commit 73e063e into master Oct 28, 2020
@skjnldsv skjnldsv deleted the fix/comments/various branch October 28, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants