Check if array elements exist before using them #23645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
MorrisJobke,
icewind1991,
juliusknorr and
nickvergessen
MorrisJobke
force-pushed
the
fix/fe/s3/isset_first
branch
from
6039965 to
3b26178
Compare
Member
|
I amended your commit, because there was one additional space behind the if statement. |
Contributor
|
Looks similar to #23591 🤔 |
kesselb
requested changes
Oct 23, 2020
rullzer
force-pushed
the
fix/fe/s3/isset_first
branch
from
3b26178 to
47c60a1
Compare
It seems that in some recent upgrade here. Not always the entries we expect are returned. So we should first check if they exist. As to not spam the log. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
MorrisJobke
force-pushed
the
fix/fe/s3/isset_first
branch
from
47c60a1 to
b7be09a
Compare
Member
Did it again, because you overwrote it 😝 |
MorrisJobke
approved these changes
Oct 25, 2020
Member
Author
|
/backport to stable20 |
Member
Author
|
/backport to stable19 |
Member
Author
|
/backport to stable18 |
nickvergessen
approved these changes
Oct 27, 2020
This was referenced Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that in some recent upgrade here. Not always the entries we
expect are returned. So we should first check if they exist. As to not
spam the log.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl