Skip to content

Make is_user_defined nullable so we can store false on oracle #24053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 3 commits into from
Nov 12, 2020
Merged

Make is_user_defined nullable so we can store false on oracle #24053

juliusknorr merged 3 commits into from
Nov 12, 2020

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 11, 2020

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessen
Make is_user_defined nullable so we can store false on oracle
7a1750a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Nov 11, 2020
@nickvergessen nickvergessen added this to the Nextcloud 21 milestone Nov 11, 2020
@nickvergessen
Copy link
Member Author

nickvergessen commented Nov 11, 2020

/backport to stable20

@nickvergessen
Copy link
Member Author

nickvergessen commented Nov 11, 2020

More tables to be added

@nickvergessen nickvergessen mentioned this pull request Nov 11, 2020
Merged
@nickvergessen
Also make direct_edit.accessed nullable
85ec5eb 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

nickvergessen commented Nov 11, 2020

Done, ready for review

@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 11, 2020
MorrisJobke
MorrisJobke reviewed Nov 11, 2020
View reviewed changes
apps/user_status/composer/composer/autoload_static.php
'OCA\\UserStatus\\Listener\\UserLiveStatusListener' => __DIR__ . '/..' . '/../lib/Listener/UserLiveStatusListener.php',
'OCA\\UserStatus\\Migration\\Version0001Date20200602134824' => __DIR__ . '/..' . '/../lib/Migration/Version0001Date20200602134824.php',
'OCA\\UserStatus\\Migration\\Version0002Date20200902144824' => __DIR__ . '/..' . '/../lib/Migration/Version0002Date20200902144824.php',
'OCA\\UserStatus\\Migration\\Version1000Date20201111130204' => __DIR__ . '/..' . '/../lib/Migration/Version1000Date20201111130204.php',
Copy link
Member

@MorrisJobke MorrisJobke Nov 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The big version jump in the migration is okay?

Copy link
Member Author

@nickvergessen nickvergessen Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well the app version is 1.0.x so its 1000 for migrations

@faily-bot
Copy link

faily-bot bot commented Nov 11, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35385: failure

checkers

Show full log 
The autoloaders are not up to date
Please run: bash build/autoloaderchecker.sh
And commit the result

@MorrisJobke
Copy link
Member

MorrisJobke commented Nov 11, 2020

The autoloaders are not up to date
Please run: bash build/autoloaderchecker.sh
And commit the result

Let me commit that.

@MorrisJobke
Dump autoloader
c27ed22 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@juliusknorr
Copy link
Member

juliusknorr commented Nov 12, 2020

Failure unrelated (mysql timing out after an hour)

@juliusknorr juliusknorr merged commit 81070c7 into master Nov 12, 2020
@juliusknorr juliusknorr deleted the bugfix/noid/fix-user-status-for-oracle branch November 12, 2020 20:43
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@blizzz blizzz blizzz approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@georgehrke georgehrke Awaiting requested review from georgehrke

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen @MorrisJobke @juliusknorr @blizzz