get only vcard which match both the address book id and the vcard uri #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Try to give yourself a approval please 😉 (to test #238) |
Member
Author
|
:invalidated+1: (just a test) |
Member
Author
|
:invalidated+1: (let's hope that it doesn't work) |
Member
Author
|
@Mar1u5 seems to work... now two real +1 please 😉 |
Member
|
👍 |
Member
|
It does still work 😒 ... One approval of you ... And one of me 😢 You should not be able to approve ... Not multiple times ... But also not once if you created the PR by yourself 😈 |
Member
|
👍 |
Member
|
@schiessle I guess this should be backported, right? |
|
Seems Legit. I cannot check it before Friday, but it looks like the Fix I have made my own. |
Member
Author
yes, @karlitschek do you agree? |
Member
|
absolutely. please backport! |
This was referenced Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #229
cc @kellertobi91 this should fix your issue, maybe you can verify it?