-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
We should always show permanent actions #2436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @icewind1991 and @jancborchardt to be potential reviewers. |
|
👍 |
|
great, this brings the restore button back! There is one small glitch, the mouse pointer changes above and below the "restore" button to indicate that you can click on it but not if you point directly to the icon or the "restore" label. |
|
Somebody that actually knows CSS and the like. Please take over ;) |
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
|
fixed the mouse pointer stuff... 👍 for @rullzer's changes |
|
Fine by me! |
|
Thanks - I added this to bring back the darker color for shared entries. This still works, so this is 👍 also from me :) |
| #fileList tr a.action.action-menu.permanent:hover, | ||
| #fileList tr a.action.action-menu.permanent:focus { | ||
| #fileList tr a.action.action.permanent:hover, | ||
| #fileList tr a.action.action.permanent:focus { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of this specificity causes the menu entries being way too big. Can you add that back @rullzer?

cc @nextcloud/designers
Should fix #2407
But it is CSS magic so summoning @nextcloud/designers
@schiessle @nickvergessen please test.