Skip to content

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Dec 1, 2016

Should fix #2407

But it is CSS magic so summoning @nextcloud/designers

@schiessle @nickvergessen please test.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added 3. to review Waiting for reviews bug labels Dec 1, 2016
@rullzer rullzer added this to the Nextcloud 11.0 milestone Dec 1, 2016
@mention-bot
Copy link

@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MorrisJobke, @icewind1991 and @jancborchardt to be potential reviewers.

@skjnldsv
Copy link
Member

skjnldsv commented Dec 1, 2016

👍

@rullzer
Copy link
Member Author

rullzer commented Dec 1, 2016

According to my bisect the commit that broke it is b75ef0f

so cc @skjnldsv

@schiessle
Copy link
Member

great, this brings the restore button back! There is one small glitch, the mouse pointer changes above and below the "restore" button to indicate that you can click on it but not if you point directly to the icon or the "restore" label.

@rullzer
Copy link
Member Author

rullzer commented Dec 1, 2016

Somebody that actually knows CSS and the like. Please take over ;)

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
@schiessle
Copy link
Member

schiessle commented Dec 1, 2016

fixed the mouse pointer stuff... 👍 for @rullzer's changes

@rullzer
Copy link
Member Author

rullzer commented Dec 1, 2016

Fine by me!

@schiessle schiessle merged commit 5cea7f3 into master Dec 1, 2016
@schiessle schiessle deleted the fix_inline_action_gone branch December 1, 2016 15:42
@MorrisJobke
Copy link
Member

Thanks - I added this to bring back the darker color for shared entries. This still works, so this is 👍 also from me :)

#fileList tr a.action.action-menu.permanent:hover,
#fileList tr a.action.action-menu.permanent:focus {
#fileList tr a.action.action.permanent:hover,
#fileList tr a.action.action.permanent:focus {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of this specificity causes the menu entries being way too big. Can you add that back @rullzer?
capture du 2016-12-02 14-41-33
cc @nextcloud/designers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trashbin: no "restore" action and missing previews

7 participants