[stable9] theming app #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
hm, for some reasons the file system tests fail on the backport. I tried to debug it and the difference between this branch with the last commit and without it is, that with the theming app the storage for the file system tests get wrapped by the trash bin and encryption storage which then fail because of the "dummy paths". Without the theming app this storage wrappers are not applied to the test storage... Does anyone has a idea why this could happen? |
Member
Sadly not :( |
schiessle
force-pushed
the
theming-app-stable9
branch
from
ad8c068 to
3cb7672
Compare
Member
|
Will have a look |
MorrisJobke
added
2. developing
Member
|
Fixed, doesn't happen on master because of the |
nickvergessen
added
3. to review
Member
|
Tested and works 👍 |
Member
Author
|
all tests successfully passed... Thanks @nickvergessen ! 👍 |
Member
|
Great to see you here at Nextcloud btw 👊 @nickvergessen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #59
please do some short tests, the backport needed quite some manual adjustments.
cc @LukasReschke @jancborchardt