Make it possible to return a search object result (with type and ID) #24410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added
3. to review
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
Ivansss,
juliusknorr,
nickvergessen and
stefan-niedermann
| $result->name, | ||
| $this->formatSubline($result), | ||
| $this->urlGenerator->getAbsoluteURL($result->link), | ||
| 'file', |
Member
There was a problem hiding this comment.
we use plurals in comments table, activity and others.
Maybe here too?
Suggested change
| 'file', | |
| 'files', |
Member
Author
|
#24474 was chosen over this one 🚀 |
ChristophWurst
deleted the
enhancement/unified-search-object-result-entry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22855
Files search provider was touched to use this new API.
@tobiasKaminsky please give it a test :)