Bump vimeo/psalm from 4.2.1 to 4.3.0 #24521
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependabot-preview
bot
added
feature: dependencies
php
dependabot-preview
bot
requested review from
ChristophWurst,
MorrisJobke and
rullzer
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
|
Joy more warnings.... |
Contributor
Author
|
A newer version of vimeo/psalm exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Member
|
Update the baseline and then it should be good :) |
rullzer
force-pushed
the
dependabot/composer/vimeo/psalm-4.3.0
branch
from
ead3f95 to
401b6b4
Compare
ChristophWurst
force-pushed
the
dependabot/composer/vimeo/psalm-4.3.0
branch
from
401b6b4 to
0876588
Compare
|
|
||
|
|
||
| $meetingUrl = $vevent->URL; | ||
| $meetingLocation = $vevent->LOCATION; |
| $absoluteURL = $this->urlGenerator->getBaseUrl(); | ||
| $parsedUrl = parse_url($absoluteURL); | ||
| if (isset($parsedUrl['port'])) { | ||
| /** @psalm-suppress RedundantCast */ |
Member
There was a problem hiding this comment.
this one felt too scary to remove. I don't trust the port to always be an int
| <code>$column</code> | ||
| </NullableReturnStatement> | ||
| </file> | ||
| <file src="lib/public/AppFramework/Db/QBMapper.php"> |
Member
There was a problem hiding this comment.
this one doesn't make sense, it's a possible Psalm regression. Reported at vimeo/psalm#4901
| <InvalidReturnType occurrences="1"> | ||
| <code>array</code> | ||
| </InvalidReturnType> | ||
| <InvalidPropertyAssignmentValue occurrences="1"> |
Member
There was a problem hiding this comment.
this one I don't get. also likely a Psalm regression but I'm still unable to isolate it
Contributor
Author
|
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
MorrisJobke
approved these changes
Jan 7, 2021
MorrisJobke
force-pushed
the
dependabot/composer/vimeo/psalm-4.3.0
branch
from
0876588 to
f39b05d
Compare
Member
Done. |
MorrisJobke
added
the
4. to release
Member
|
CI says no |
MorrisJobke
added a commit
that referenced
this pull request
Jan 11, 2021
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see #24521) Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
added a commit
that referenced
this pull request
Jan 11, 2021
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see #24521) Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Member
|
Let's move it forward in pieces: #25073 |
MorrisJobke
added a commit
that referenced
this pull request
Jan 11, 2021
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see #24521) Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
reviewed
Jan 11, 2021
lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php
Outdated
Show resolved
Hide resolved
Bumps [vimeo/psalm](https://github.com/vimeo/psalm) from 4.2.1 to 4.3.0. - [Release notes](https://github.com/vimeo/psalm/releases) - [Commits](vimeo/psalm@4.2.1...4.3.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
MorrisJobke
force-pushed
the
dependabot/composer/vimeo/psalm-4.3.0
branch
from
f39b05d to
ad3de0f
Compare
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 1260: failurenodbShow full logsqliteShow full logmariadb10.1-php7.3Show full logmariadb10.4-php7.4Show full logmysql8.0-php7.4Show full logpostgres9.6-php7.3Show full logpostgres11-php7.4Show full logpostgres12-php7.4Show full logpostgres13-php7.4Show full log |
Member
|
@dependabot-bot recreate |
Contributor
Author
|
Superseded by #25574. |
dependabot-preview
bot
deleted the
dependabot/composer/vimeo/psalm-4.3.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps vimeo/psalm from 4.2.1 to 4.3.0.
Release notes
Sourced from vimeo/psalm's releases.
Commits
6f91655Ref #4753 - allow int literals to inform key typedb8a3abFix #4751 - allow MethodSignatureMismatch to be overridable when info comes f...e2bb02eDon’t suggest a potential value that’s undefinedb64eb6dBreak out array_key_exists testsa2b20f0Fix #4752 - add property base assertions too496ce46Break out methodf0876b8Avoid false-positives while analysing memoised coalesce394ecebMemoize coalesce expression in more scenarios928fddaDon’t do new isset conversion on try-set vars1feca32Fix loading imported functionsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot will merge this PR once CI passes on it, as requested by @MorrisJobke.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: