Harden files drop #2471
Merged
Harden files drop #2471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fail on MKCOL * Only take filename ignore directories * No need to parse query parameters Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
|
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SergioBertolinSG, @LukasReschke and @MorrisJobke to be potential reviewers. |
LukasReschke
requested changes
Dec 2, 2016
.htaccess
Outdated
| #### DO NOT CHANGE ANYTHING ABOVE THIS LINE #### | ||
|
|
||
| ErrorDocument 403 //core/templates/403.php | ||
| ErrorDocument 404 //core/templates/404.php |
|
|
||
| try { | ||
| $this->response = $client->send($client->createRequest("PUT", $fullUrl, $options)); | ||
| var_dump($fullUrl); |
LukasReschke
reviewed
Dec 2, 2016
| } | ||
|
|
||
| $base = substr($this->baseUrl, 0, -4); | ||
| $fullUrl = $base . '/public.php/webdav/' . $folder . '?XDEBUG_SESSION_START=1'; |
LukasReschke
previously requested changes
Dec 2, 2016
|
|
||
| try { | ||
| $this->response = $client->send($client->createRequest("POST", $fullUrl, $options)); | ||
| $this->response = $client->send($client->createRequest("POST", $fullUrl . '?XDEBUG_SESSION_START=1', $options)); |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
harden_files_drop
branch
from
0491669 to
2de0992
Compare
Member
Author
|
Fixes #2083 |
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Member
|
I fixed the tests - you need to install the instance before running integration tests ;) |
Member
|
I tested the files drop feature and it still works 👍 |
Member
Author
|
Aaaah copied the wrong intergration test as example :P |
LukasReschke
approved these changes
Dec 2, 2016
Member
LukasReschke
left a comment
LukasReschke
left a comment
There was a problem hiding this comment.
Works nicely! Thanks, @rullzer! 🚀
LukasReschke
added
4. to release
Member
|
LGTM |
This was referenced Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LukasReschke as discussed.
Fixes #2083