Skip to content

Fix ldap css and jquery ui css fix for menu dropdown #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
skjnldsv wants to merge 5 commits into from
Closed

Fix ldap css and jquery ui css fix for menu dropdown #2529

skjnldsv wants to merge 5 commits into from

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 6, 2016 •
edited
Loading

refs: #1932 #1780 #2524

capture d ecran_2016-12-06_13-14-42

@MorrisJobke @nextcloud/designers

@skjnldsv skjnldsv added 3. to review Waiting for reviews bug design Design, UI, UX, etc. enhancement labels Dec 6, 2016
@skjnldsv skjnldsv added this to the Nextcloud 11.0 milestone Dec 6, 2016
@mention-bot
Copy link

mention-bot commented Dec 6, 2016

@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @jancborchardt and @individual-it to be potential reviewers.

@skjnldsv
Global design
14dda02 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Jquery ui fixes corrected to dropdown only
93aeadd 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Load icons after everything to override background
918e455 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Fix loader
dc8d728 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Fix popup display
f07e4a0 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 6, 2016 •
edited
Loading

Rebased and ready to merge! 🚀

@MorrisJobke
Copy link
Member

MorrisJobke commented Dec 6, 2016

@blizzz Could you have a look at this?

@codecov-io
Copy link

codecov-io commented Dec 6, 2016

Current coverage is 57.21% (diff: 20.00%)

Merging #2529 into master will increase coverage by <.01%

@@             master      #2529   diff @@
==========================================
  Files          1202       1202          
  Lines         72470      72466     -4   
  Methods        7365       7365          
  Messages          0          0          
  Branches       1228       1228          
==========================================
+ Hits          41463      41465     +2   
+ Misses        31007      31001     -6   
  Partials          0          0
Diff Coverage File Path
0% apps/user_ldap/templates/part.wizard-server.php
•••••••••• 100% lib/private/legacy/template.php

Powered by Codecov. Last update b190153...f07e4a0

@blizzz
Copy link
Member

blizzz commented Dec 7, 2016

Advanced tab does not use the available space properly:

spectacle a18316

Looks good otherwise!

@LukasReschke
Copy link
Member

LukasReschke commented Dec 11, 2016

@skjnldsv Can we move that to 12? I'd prefer to consider 11 closed for any non-critical merges.

@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 12, 2016

@LukasReschke If you want! :)
It'w not really a game-changing pr ;)

@blizzz blizzz modified the milestones: Nextcloud 12.0, Nextcloud 11.0 Dec 12, 2016
@LukasReschke
Copy link
Member

LukasReschke commented Dec 16, 2016

Ok. – Master is open again so I suppose we need to fix #2529 (comment) and then can merge this?

@skjnldsv
Copy link
Member Author

skjnldsv commented Dec 16, 2016

@LukasReschke Exactly. I didn't had the time yet.

@skjnldsv skjnldsv self-assigned this Dec 18, 2016
@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 22, 2016
@skjnldsv skjnldsv mentioned this pull request Jan 22, 2017
Merged
@LukasReschke
Copy link
Member

LukasReschke commented Feb 20, 2017

@skjnldsv Is this still interesting? If not we should probably close this 😉

@skjnldsv
Copy link
Member Author

skjnldsv commented Feb 20, 2017 •
edited
Loading

I need to rework this with the scss :)
Leave it open 🎉

@jancborchardt jancborchardt requested a review from blizzz April 25, 2017 12:30
@jancborchardt jancborchardt added this to the Nextcloud 13 milestone Apr 25, 2017
@jancborchardt jancborchardt removed this from the Nextcloud 12.0 milestone Apr 25, 2017
@jancborchardt
Copy link
Member

jancborchardt commented Apr 25, 2017

Moving to Nextcloud 13 then as we have feature freeze tomorrow. :)

@MorrisJobke
Copy link
Member

MorrisJobke commented Sep 5, 2017

@skjnldsv I guess most of this in here was fixed by #6341 - can we close this then?

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 5, 2017

Ehheh, yes we can! 💪

@skjnldsv skjnldsv closed this Sep 5, 2017
@blizzz blizzz deleted the fix-ldap-css branch September 5, 2017 14:37
@MorrisJobke MorrisJobke removed this from the Nextcloud 13 milestone Sep 5, 2017
@violethaze74 violethaze74 mentioned this pull request Aug 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@skjnldsv skjnldsv

Labels

2. developing Work in progress bug design Design, UI, UX, etc. enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@skjnldsv @mention-bot @MorrisJobke @codecov-io @blizzz @LukasReschke @jancborchardt