Check command input #25890
Merged
Check command input #25890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For #25839 We should check this else it crashed hard. Better to be gracefull. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
Azelphur,
ChristophWurst,
Dagefoerde,
LukasReschke,
MorrisJobke,
affan-hussain,
artemanufrij,
bfritscher,
coliff,
danjpgriffin,
fl4p,
julien-nc,
juliusknorr,
kesselb and
solracsf
Contributor
|
I would typecast the input. Null is not possible as a default is defined. |
kesselb
approved these changes
Mar 2, 2021
LukasReschke
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #25839
We should check this else it crashed hard. Better to be gracefull.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl