[stable19] No longer add trusted servers on federated share creation #26780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
LukasReschke,
MorrisJobke,
nickvergessen and
rullzer
Member
|
I'll look into the diff of the backport. |
LukasReschke
requested changes
Apr 27, 2021
Member
LukasReschke
left a comment
LukasReschke
left a comment
There was a problem hiding this comment.
Checking conflicts locally
It was disabled by default for ages. And often resulted in unwanted behavior. If admins want trusted servers they just have to do it manually. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
LukasReschke
force-pushed
the
backport/26765/stable19
branch
from
dc8e898 to
771dfc8
Compare
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
LukasReschke
approved these changes
Apr 27, 2021
Member
LukasReschke
left a comment
LukasReschke
left a comment
There was a problem hiding this comment.
Tested locally and I was able to send a share out, and the UI for the auto add doesn't appear anymore.
rullzer
approved these changes
Apr 28, 2021
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #26765