[stable20] Fix missing label of Search function #28246
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
added
bug
design
backportbot-nextcloud
bot
requested review from
jancborchardt,
juliusknorr,
marcoambrosini,
nimishavijay and
skjnldsv
Member
|
/compile amend / |
juliusknorr
approved these changes
Jul 30, 2021
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
nextcloud-command
force-pushed
the
backport/28238/stable20
branch
from
d7b5b58 to
2a92ebc
Compare
skjnldsv
approved these changes
Jul 30, 2021
jancborchardt
approved these changes
Jul 30, 2021
jancborchardt
requested changes
Jul 30, 2021
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Seems the ariaLabel prop only exists in UnifiedSearch.vue since Nextcloud 21. Do we want to only backport til then and drop this one? @skjnldsv @juliushaertl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #28238