[stable22] Fix users can't login external mount user entered credentials not set #29638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using external mount with "Global credentials, user entered", users without it set won't be able to login.
This happens because BasicAuth requires username and password as string, but will be null when user didn't set it yet.
It happens because since the commit: 66781e7 update icewind/smb to 3.4.0
the file
apps/files_external/3rdparty/icewind/smb/src/BasicAuth.phpwas changed to use php 7.4 typed properties.BasicAuth with username as null throws TypeError:
apps/files_external/lib/Lib/Backend/SMB.phpTypeError is a subclass of Error, not a subclass of Exception, it won't catch it at FailedStorage:
apps/files_external/lib/Config/ConfigAdapter.phpThe proposed fix is to check if user and password is string instead of null, and throw InvalidArgumentException if it's not.
apps/files_external/lib/Lib/Backend/SMB.phpThis commit can be cherry-picked to master, stable22, stable21.
Fix #28229 .
Fix #26697 .