Skip to content

Clarify preview_max_filesize_image behavior #30225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
szaimen merged 2 commits into from
Feb 21, 2022
Merged

Clarify preview_max_filesize_image behavior #30225

szaimen merged 2 commits into from
Feb 21, 2022

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Dec 12, 2021

Fix #30220

@solracsf solracsf added the 3. to review Waiting for reviews label Dec 12, 2021
@szaimen
Copy link
Contributor

szaimen commented Jan 31, 2022

/rebase

@szaimen szaimen requested a review from MichaIng January 31, 2022 07:02
@szaimen szaimen added this to the Nextcloud 24 milestone Jan 31, 2022
@szaimen
Copy link
Contributor

szaimen commented Feb 20, 2022

/rebase

@MichaIng
Copy link
Member

MichaIng commented Feb 20, 2022

Drone failure is unrelated: #31143 (comment)

@szaimen
Copy link
Contributor

szaimen commented Feb 21, 2022

@acsfer please fix dco then I'll merge

@solracsf
Copy link
Member Author

solracsf commented Feb 21, 2022

Fixed

@szaimen
Copy link
Contributor

szaimen commented Feb 21, 2022

Fixed

That was not what I meant but okay 😂

@szaimen szaimen merged commit 99e7f33 into master Feb 21, 2022
@szaimen szaimen deleted the fix-30220 branch February 21, 2022 09:39
@szaimen
Copy link
Contributor

szaimen commented Feb 21, 2022

BTW: @acsfer do you mind also clarifying the flag in the documentation?

@solracsf
Copy link
Member Author

solracsf commented Feb 21, 2022

Where exactly?

@szaimen
Copy link
Contributor

szaimen commented Feb 21, 2022

here: https://github.com/nextcloud/documentation/blob/b0d15109fa8140593f14f8751d944e6781076ca8/admin_manual/configuration_server/config_sample_php_parameters.rst#:~:text='preview_max_filesize_image'%20%3D%3E%2050%2C

solracsf added a commit to nextcloud/documentation that referenced this pull request Feb 21, 2022
@solracsf
Follow up server PR #30225
6710381 
nextcloud/server#30225
@solracsf solracsf mentioned this pull request Feb 21, 2022
Merged
@solracsf
Copy link
Member Author

solracsf commented Feb 21, 2022

nextcloud/documentation#8082

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaIng MichaIng MichaIng approved these changes

@szaimen szaimen szaimen approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

Image file size bigger than preview_max_filesize_image won't display

4 participants

@solracsf @szaimen @MichaIng