Fit federationScopeMenu to guidelines #3035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
3. to review
|
@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ChristophWurst, @schiessle and @LukasReschke to be potential reviewers. |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix-federationScopeMenu-menu
branch
from
75abd75 to
a3e3111
Compare
Member
Author
|
Also, after #3024, I added the center class to menu. We could probably get rid of the js magic for the popups :) |
ChristophWurst
approved these changes
Jan 12, 2017
MorrisJobke
approved these changes
Jan 12, 2017
This was referenced Jan 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The open class is needed only when opened.
After #3024 the workarround will not work and the design will have to fit the css guidelines :)