Skip to content

Conversation

@skjnldsv
Copy link
Member

Should be useful for occasional popover sub-items (like the upload file menu for example)

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 3. to review Waiting for reviews design Design, UI, UX, etc. feature: scss labels Jan 17, 2017
@skjnldsv skjnldsv added this to the Nextcloud 12.0 milestone Jan 17, 2017
@skjnldsv skjnldsv self-assigned this Jan 17, 2017
@ChristophWurst
Copy link
Member

Should be useful

So is this actually useful now? How can we test this?

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 17, 2017

Well in the popover menus, we aim for 'a' or 'button' only children, but since the upload popovers (gallery and files) are using a label to link it to the input file I thought we should add it for compatibility with old apps and for occasional uses like these. :)

you can test it by clicking the add file button on files or gallery (which require some more fixes too)

@ChristophWurst
Copy link
Member

which require some more fixes too

What happened there? 😁 We definitely have to fix that

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improves the add/upload files popover in files

@skjnldsv
Copy link
Member Author

What happened there? 😁 We definitely have to fix that

Incoming.
We need to get rid of that javascript magic.

@schiessle
Copy link
Member

definitely a improvement, compared with master 👍

@schiessle schiessle merged commit 61c68d4 into master Jan 17, 2017
@schiessle schiessle deleted the menuitem-fix branch January 17, 2017 10:12
@skjnldsv skjnldsv mentioned this pull request Jan 17, 2017
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. feature: scss

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants