Fix caching of the user avatar #31354
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now on firefox/safari it is only refetched once a day. On Chrom{e,ium}
we keep the previous behavior of maybe refetching it more often.
This also notify the user about this behavior when they upload an avatar
picture.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
requested review from
ArtificialOwl and
juliusknorr
and removed request for
a team
MichaIng
reviewed
Feb 28, 2022
nickvergessen
approved these changes
Feb 28, 2022
MichaIng
approved these changes
Feb 28, 2022
solracsf
reviewed
Mar 1, 2022
Signed-off-by: Carl Schwan <carl@carlschwan.eu> Co-authored-by: MichaIng <micha@dietpi.com> Co-authored-by: zroebg <carlos@reendex.com>
CarlSchwan
force-pushed
the
fix/caching-avatar
branch
from
fac5b16 to
2ebffc0
Compare
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
|
The backport to stable22 failed. Please do this backport manually. |
|
The backport to stable23 failed. Please do this backport manually. |
Member
|
Backports failed 😞 |
This was referenced Mar 2, 2022
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now on firefox/safari it is only fetched once a day. On Chrom{e,ium}
we keep the previous behavior of maybe fetching it more often (random
probability).
This also notifies the user about this behavior when they upload an avatar
picture.
Signed-off-by: Carl Schwan carl@carlschwan.eu