Delay loading user preferences until we need them #31363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
2. developing
nickvergessen
force-pushed
the
techdebt/noid/delay-getting-preferences
branch
from
bff1326 to
515808f
Compare
nickvergessen
added
3. to review
nickvergessen
requested review from
a team,
CarlSchwan,
PVince81,
blizzz,
danxuliu and
vitormattos
and removed request for
a team and
blizzz
CarlSchwan
approved these changes
Feb 28, 2022
Member
CarlSchwan
left a comment
CarlSchwan
left a comment
There was a problem hiding this comment.
Looks good, just one small thing to fix
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
techdebt/noid/delay-getting-preferences
branch
from
515808f to
b90e657
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps in certain requests to drastically reduce the number of queries