be conservative when reading from fresh created column #31436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
added
2. developing
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/noid/migration-column-handling
branch
from
e6a67c1 to
f3668f2
Compare
PVince81
approved these changes
Mar 3, 2022
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍 makes sense, but please fix the indents and make them consistent
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Member
Author
the odd indents turned out to be a Microsoft Github presentation bug |
nickvergessen
approved these changes
Mar 4, 2022
CarlSchwan
approved these changes
Mar 4, 2022
Member
|
/backport to stable23 |
Member
|
/backport to stable22 |
Member
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
|
The backport to stable21 failed. Please do this backport manually. |
|
The backport to stable20 failed. Please do this backport manually. |
This was referenced Mar 21, 2022
blizzz
added
4. to release
Member
Author
|
backports to 21 and 20 done manually ^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a column was added into a table definition we may run into risk that when it is read it may happen on a DB node where the column is not synced to, yet. Then the where clause is also not necessary since all rows qualify.