Skip to content

Fix #3174 #3190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Jan 22, 2017
Merged

Fix #3174 #3190

skjnldsv merged 1 commit into from
Jan 22, 2017

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 21, 2017 •
edited by MorrisJobke
Loading

A small misalignment because it's best with #3187
And:

  • Prepared for the new inputs.scss
  • Fit popover to guidelines
  • Fixed some css

@skjnldsv
Fix #3174
f40e5b7 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 3. to review Waiting for reviews design Design, UI, UX, etc. feature: scss labels Jan 21, 2017
@skjnldsv skjnldsv added this to the Nextcloud 12.0 milestone Jan 21, 2017
@skjnldsv skjnldsv self-assigned this Jan 21, 2017
@mention-bot
Copy link

mention-bot commented Jan 21, 2017

@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @jancborchardt and @ChristophWurst to be potential reviewers.

MorrisJobke
MorrisJobke approved these changes Jan 21, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍
bildschirmfoto 2017-01-21 um 16 54 20

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 22, 2017

@LukasReschke quick one :)

@skjnldsv skjnldsv merged commit 7eec5e0 into master Jan 22, 2017
@skjnldsv skjnldsv deleted the fix-sharing-popover branch January 22, 2017 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@LukasReschke LukasReschke LukasReschke approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. feature: scss

Projects

None yet

Milestone

Nextcloud 12.0

Development

Successfully merging this pull request may close these issues.

Unshare menu has too high line-height

5 participants

@skjnldsv @mention-bot @MorrisJobke @LukasReschke