Fix scanning app data with metadata #32033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
reviewed
Apr 21, 2022
skjnldsv
approved these changes
Apr 22, 2022
CarlSchwan
force-pushed
the
fix/metadata-scan-app-data
branch
from
3b4efc7 to
046414a
Compare
skjnldsv
requested changes
Apr 22, 2022
Previously we were listening to change in the appdata folder but an appdata scan didn't setup the file system, so the view was unavailable. **Test plan:** 1. rm -rf data/appdata_...../preview data/<user>/Media 2. occ files:scan-app-data 3. occ files:scan <user> No errors and the files and metadata are correctly removed from the database too. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
fix/metadata-scan-app-data
branch
from
046414a to
6b6f24c
Compare
skjnldsv
approved these changes
Apr 22, 2022
Member
|
/backport to stable24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were listening to changes in the appdata folder but an
appdata scan didn't set up the file system, so the view was unavailable.
Test plan:
rm -rf data/appdata_...../preview data/<user>/Mediaocc files:scan-app-dataocc files:scan <user>No errors and the files and metadata are correctly removed from the
database too.
Fix #32031