Fix metadata extraction #32982
Merged
Fix metadata extraction #32982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metadata extraction only happens when the size is not equal to 0, but due to a regression in FileInfo the size is always zero. This fix the regression. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
requested review from
PVince81 and
come-nc
and removed request for
a team
Member
Author
|
/backport to stable24 |
artonge
approved these changes
Jun 22, 2022
Member
Author
|
Tested with s3 + encryption and s3 without encryption and it seems to work fine: image are uploaded and metadata is extracted |
come-nc
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata extraction only happens when the size is not equal to 0,
but due to a regression in FileInfo the size is always zero.
This fix the regression.
Signed-off-by: Carl Schwan carl@carlschwan.eu