Skip to content

Fix for Win Clients sometimes not connecting #3370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 1 commit into from
Mar 1, 2017
Merged

Fix for Win Clients sometimes not connecting #3370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .htaccess
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@
</IfModule>
<IfModule mod_rewrite.c>
RewriteEngine on
RewriteCond %{HTTP_USER_AGENT} DavClnt
RewriteRule ^$ /remote.php/webdav/ [L,R=302]
Copy link
Member

@MorrisJobke MorrisJobke Feb 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only works for the root directory and if the RewriteBase is set. Please add this to

server/lib/private/Setup.php

Line 448 in d548329

$content .= "\n RewriteRule ^core/js/oc.js$ index.php [PT,E=PATH_INFO:$1]";
and remove the leading / before remote.php to be compatible with sub folders. Then this is good to go in

Copy link
Contributor

@michag86 michag86 Feb 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my case RewriteBase was not in use and ist works.

And it's only required for the root directory. If Nextcloud ist installed in a sub directory, the problem does not occour.

Copy link
Member

@MorrisJobke MorrisJobke Feb 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it's only required for the root directory. If Nextcloud ist installed in a sub directory, the problem does not occour.

But we would redirect to /remote.php/webdav/ instead of ´/sub/remote.php/webdav/`... even if it is never requested like this it could cause huge headaches.

@LukasReschke @nickvergessen Opinions of introducing a rewrite condition that works and fixes a problem if installed in root, but creates a redirect to "outside of nextcloud" for the sub directory install, but there it is never requested by Windows anyways. (I tested this and it works)

Copy link
Contributor

@michag86 michag86 Feb 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Nextcloud ist installed in a sub directory, the "RewriteRule ^$" in the .htaccess of the sub directory will do nothing. Or am I wrong?

Copy link
Member

@MorrisJobke MorrisJobke Feb 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Nextcloud ist installed in a sub directory, the "RewriteRule ^$" in the .htaccess of the sub directory will do nothing. Or am I wrong?

It does, because it get's only the stuff handed in within it's subdirectory. And then it redirect to the root (because of the leading slash in /remote.php/dav). Therefore I tested this with windows and it doesn't request the subdirectory.

RewriteRule .* - [env=HTTP_AUTHORIZATION:%{HTTP:Authorization}]
RewriteRule ^\.well-known/host-meta /public.php?service=host-meta [QSA,L]
RewriteRule ^\.well-known/host-meta\.json /public.php?service=host-meta-json [QSA,L]
Expand Down