Don't log the password on confirmPassword when LDAP throws an exception #3396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bartv2, @MorrisJobke and @BernhardPosselt to be potential reviewers. |
Codecov Report@@ Coverage Diff @@
## master #3396 +/- ##
=========================================
Coverage 53.99% 53.99%
Complexity 21007 21007
=========================================
Files 1303 1303
Lines 80373 80373
Branches 1253 1253
=========================================
Hits 43395 43395
Misses 36978 36978
Continue to review full report at Codecov.
|
MorrisJobke
approved these changes
Feb 7, 2017
Member
|
@nickvergessen Backport? :) |
Member
Author
|
backport in #3414 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling coding@schilljs.com