Files version improvements #34771
Files version improvements #34771
Conversation
CarlSchwan
force-pushed
the
port/vue/files_version
branch
2 times, most recently
from
8d425cc to
90023c6
Compare
Simplify code and make it use our standard components Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
port/vue/files_version
branch
from
90023c6 to
2bb7385
Compare
Simplify code and make it use our standard components Signed-off-by: Carl Schwan <carl@carlschwan.eu>
For now frontend only, backend will follow soon™ - Add avatar of the user who made the change - Allow to mark a version as favorite (goal is that these versions are persistent) Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
files_version_improvements
branch
from
69d1c13 to
7156851
Compare
|
Some general thoughts on showing the user that made the change, for collaborative editing it would be quite nice if the version could also be created by an app (in terms of the metadata stored) and have a list of users that worked on the version. Common use cases would be apps like text or Office where users work together on a certain set of changes until the save is happening either through autosave or the manual save operation of a user. I'm not sure in which phase you are regarding the backend implementation and if this would be in scope for the planned change, so just leaving this here for consideration. |
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Backend is currently not implemented, but I had some rough idea how it would work. I didn't think about multiple users could be doing one change scenario from office. Thanks for pointing it out, if you have any ideas on how this would look like api wise, let me know ;) |
CarlSchwan
force-pushed
the
port/vue/files_version
branch
2 times, most recently
from
0118d60 to
859523d
Compare
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Nice! :) Some design feedback:
- The wording of the menu is much too complex – as per the spec at https://github.com/nextcloud-gmbh/customer-feature-requests/issues/189#issuecomment-1257905430 it can simply be: "Name this version" (or "Edit version name" if name is set), "Download version", "Restore version" and "Delete version".
- The icon in the tab header can be the same as the one you used for the emptycontent and the buttons
- Modal:
- "Name this version" could be modal heading and the input label as well for simplicity?
- The explanatory note below the field can be
color-text-maxcontrast - The button should be "Save version name" and on the right, also as per spec
- We should have a specific "Cancel" button on the left
artonge
force-pushed
the
port/vue/files_version
branch
4 times, most recently
from
c5a7016 to
b094abd
Compare
|
Ah, didn't see this PR before starting #35080 |
For now frontend only, backend will follow soon™
persistent)
Build on top of #34769