Skip to content

Remove unused legacy ajax/list.php in files app #35980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 1 commit into from
Jan 10, 2023
Merged

Remove unused legacy ajax/list.php in files app #35980

PVince81 merged 1 commit into from
Jan 10, 2023

Conversation

@PVince81
Copy link
Member

@PVince81 PVince81 commented Jan 4, 2023

Summary

Remove unused legacy ajax/list.php in files app

Tests

  • spreed app is not using the code block saying that spreedme was using it: file picker works fine still
  • tested file list
  • tested public file list
  • tested trashbin file list

Checklist

@PVince81 PVince81 added 3. to review Waiting for reviews technical debt labels Jan 4, 2023
@PVince81 PVince81 added this to the Nextcloud 26 milestone Jan 4, 2023
@PVince81 PVince81 self-assigned this Jan 4, 2023
@PVince81 PVince81 mentioned this pull request Jan 4, 2023
Merged
13 tasks
@skjnldsv
Copy link
Member

skjnldsv commented Jan 4, 2023

Can you rebase onto #35772?
So I don't have to rebase? Or we merge after it

@PVince81
Copy link
Member Author

PVince81 commented Jan 4, 2023

@skjnldsv let's merge yours first, it has higher priority. then I'll rebase :-)

come-nc
come-nc approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@PVince81 PVince81 force-pushed the remove-legacy-ajax-list branch from 7a4c69e to ece280c Compare January 5, 2023 08:45
@PVince81
Copy link
Member Author

PVince81 commented Jan 5, 2023

rebased with conflicts solved

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 5, 2023
@skjnldsv
Copy link
Member

skjnldsv commented Jan 5, 2023

Needs a node compile then :)

@PVince81
Copy link
Member Author

PVince81 commented Jan 5, 2023

/compile amend /

@PVince81
Remove unused legacy ajax/list.php in files app
42d9e08 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@PVince81 PVince81 force-pushed the remove-legacy-ajax-list branch from 374b4ab to 42d9e08 Compare January 9, 2023 14:18
@PVince81 PVince81 merged commit 4ecf4b4 into master Jan 10, 2023
@PVince81 PVince81 deleted the remove-legacy-ajax-list branch January 10, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@come-nc come-nc come-nc approved these changes

Assignees

@PVince81 PVince81

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt

Projects

None yet

Milestone

Nextcloud 26

Development

Successfully merging this pull request may close these issues.

5 participants

@PVince81 @skjnldsv @artonge @come-nc