fix(files) Call .action of local element instead of global page #36331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
a team,
Pytal,
artonge and
szaimen
and removed request for
a team
artonge
reviewed
Jan 25, 2023
artonge
approved these changes
Jan 30, 2023
Contributor
|
@tpayen can you fix DCO ? |
When calling .action from the global page, newButton may conflict with other app-content which is similar to app-content-files Signed-off-by: Thomas Payen <thomas.payen@i-carre.net>
tpayen
force-pushed
the
fix/globalNewButton
branch
from
fe53c22 to
87887d7
Compare
Contributor
Author
done ! |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Contributor
|
Cypress failure unrelated, and should be fixed by #36455 |
Contributor
|
Thanks @tpayen ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When calling .action from the global page, newButton may conflict with other app-content which is similar to app-content-files. Calling .action from the local element allow to have multiple newButtons
Checklist