Fix saving backup codes by using a correct data uri #3649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added
3. to review
|
@ChristophWurst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen to be a potential reviewer. |
LukasReschke
approved these changes
Feb 28, 2017
Member
LukasReschke
left a comment
LukasReschke
left a comment
There was a problem hiding this comment.
Works. And as this is rather severe this should also be backported ;-)
Codecov Report
@@ Coverage Diff @@
## master #3649 +/- ##
=========================================
Coverage 54.31% 54.31%
Complexity 20926 20926
=========================================
Files 1297 1297
Lines 79830 79830
Branches 1254 1254
=========================================
Hits 43360 43360
Misses 36470 36470Continue to review full report at Codecov.
|
Member
|
backport makes sense 👍 Thanks a lot. |
rullzer
approved these changes
Feb 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3520
Was caused by #2704, where I apparently only tested printing the codes …
Tested with FF and Chrome, both printing and saving the backup codes works as expected.
@LukasReschke @karlitschek shall I prepare a backport for nc11?