Skip to content

filelist only refreshed if directory changes #3686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Mar 3, 2017
Merged

filelist only refreshed if directory changes #3686

nickvergessen merged 1 commit into from
Mar 3, 2017
+23 −0

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 3, 2017 •
edited
Loading

@noveens @MorrisJobke
filelist only refreshed if directory changes
93f9db4 
check introduced at another method

comment added to explain one check

comment added to explain one check

unit tests added

small fixes in unit tests

missing semicolon added

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews downstream labels Mar 3, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone Mar 3, 2017
@mention-bot
Copy link

mention-bot commented Mar 3, 2017

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @butonic, @ChristophWurst and @icewind1991 to be potential reviewers.

@MorrisJobke MorrisJobke mentioned this pull request Mar 3, 2017
Closed
@MorrisJobke MorrisJobke requested a review from Bugsbane March 3, 2017 03:46
@nickvergessen nickvergessen merged commit 29e9b1f into master Mar 3, 2017
@nickvergessen nickvergessen deleted the downstream-27282 branch March 3, 2017 10:56
@oparoz oparoz mentioned this pull request Mar 5, 2017
Closed
@ChristophWurst ChristophWurst mentioned this pull request Apr 11, 2017
Closed
rullzer added a commit that referenced this pull request Apr 11, 2017
@rullzer
Do reload shared views
8c01e45 
Fixes #4248

The magic introduced in #3686 caused the shared views not to be updated
properly. Thus we just overwrite the _onUrlChange method in the
sharedfilelist.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer mentioned this pull request Apr 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@oparoz oparoz Awaiting requested review from oparoz

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Bugsbane Bugsbane Awaiting requested review from Bugsbane

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 12.0

Development

Successfully merging this pull request may close these issues.

File list sometimes refreshes after closing picture or video viewer

6 participants

@MorrisJobke @mention-bot @rullzer @nickvergessen @noveens